Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I used the original vinsmono and got different results from your paper. Why is that? #2

Closed
ChenHuang20 opened this issue Apr 14, 2021 · 11 comments

Comments

@ChenHuang20
Copy link

I used the ol_market1_config.yaml file of your rp-vio project to directly run VINS-MONO on the OpenLORIS-market-1 dataset, and got a higher accuracy than your paper (paper is 2.45, but I got Absolute Trajectory RMSE = 0.88). Why?

The evaluation tool I use is EVO, and the link is [https://github.com/MichaelGrupp/evo]

The command is evo_ape tum groundtruth.txt vins_result_no_loop.txt -va -p --plot_mode=xyz --align --correct_scale

Looking forward to your answer

@ChenHuang20
Copy link
Author

The OpenLORIS-market-1 dataset is as same as yours

@karnikram
Copy link
Owner

karnikram commented Apr 14, 2021 via email

@karnikram
Copy link
Owner

karnikram commented Apr 14, 2021 via email

@ChenHuang20
Copy link
Author

ChenHuang20 commented Apr 15, 2021

Hi, bro
I run vins-mono and evaluate it with evo_ape tum groundtruth.txt vins_result_no_loop.txt -va -p --plot_mode=xyz --align

I get rmse = 1.128904

Then I run rpvio with roslaunch rpvio_estimator ol_market1.launch and evaluate it with sh run_ol_market1.sh

I get rmse = 1.242076

why the error from VINS-Mono still be lesser than RP-VIO? same ol_market_config.yaml and computer

@karnikram
Copy link
Owner

Hi,

The config file which you've used is specific to RP-VIO and differs from the default VINS-Mono parameters. I just noticed that I haven't uploaded the config file that we used for evaluating VINS-Mono. Here it is for the OL sequence -
vins_market1_config.txt. Importantly, this uses the default VINS-Mono feature tracking parameters, which is what was used in our experiments.

RP-VIO needs different parameters (provided in ol_market1_config.yaml) than the default VINS-Mono parameters to run well since it generally focuses on smaller regions of the scene. This parameter was still fixed across all datasets for the evaluations reported in the paper. For VINS-MONO, we sticked to the default provided parameters. Your result with different parameters is certainly interesting.

Thanks for reporting and please let me know about your results with this updated config file. I will also try including the VINS-Mono evaluation scripts that we used in the repo.

@ChenHuang20
Copy link
Author

Hi,
I run vins-mono with your config file 3 times and got 1.55, 2.22, and 1.65 rmse.
The results from VINS-Mono are more than RP-VIO.

@Gatsby23
Copy link

Hi,
I run vins-mono with your config file 3 times and got 1.55, 2.22, and 1.65 rmse.
The results from VINS-Mono are more than RP-VIO.

Have you run the segmentation part ?
When I run python inference.py, I got this:

from RecoverPlane import RecoverPlane
ModuleNotFoundError: No module named 'RecoverPlane

Have you met this error before?

@ChenHuang20 ChenHuang20 mentioned this issue Jun 25, 2021
Closed
@ChenHuang20
Copy link
Author

Hi,
I run vins-mono with your config file 3 times and got 1.55, 2.22, and 1.65 rmse.
The results from VINS-Mono are more than RP-VIO.

Have you run the segmentation part ?
When I run python inference.py, I got this:

from RecoverPlane import RecoverPlane
ModuleNotFoundError: No module named 'RecoverPlane

Have you met this error before?

I run the segmentation part,but I didn't get this error

@Gatsby23
Copy link

Hi,
I run vins-mono with your config file 3 times and got 1.55, 2.22, and 1.65 rmse.
The results from VINS-Mono are more than RP-VIO.

Have you run the segmentation part ?
When I run python inference.py, I got this:
from RecoverPlane import RecoverPlane
ModuleNotFoundError: No module named 'RecoverPlane
Have you met this error before?

I run the segmentation part,but I didn't get this error

How to run the segmentation part? could you please give me some advices? What is your OS ?

@ChenHuang20
Copy link
Author

Hi,
I run vins-mono with your config file 3 times and got 1.55, 2.22, and 1.65 rmse.
The results from VINS-Mono are more than RP-VIO.

Have you run the segmentation part ?
When I run python inference.py, I got this:
from RecoverPlane import RecoverPlane
ModuleNotFoundError: No module named 'RecoverPlane
Have you met this error before?

I run the segmentation part,but I didn't get this error

How to run the segmentation part? could you please give me some advices? What is your OS ?

There is no need to run segmentation part separately, because the segmentation part is in the datasets, just download the author’s datasets and follow the command provided by the author to run

@Gatsby23
Copy link

Hi,
I run vins-mono with your config file 3 times and got 1.55, 2.22, and 1.65 rmse.
The results from VINS-Mono are more than RP-VIO.

Have you run the segmentation part ?
When I run python inference.py, I got this:
from RecoverPlane import RecoverPlane
ModuleNotFoundError: No module named 'RecoverPlane
Have you met this error before?

I run the segmentation part,but I didn't get this error

How to run the segmentation part? could you please give me some advices? What is your OS ?

There is no need to run segmentation part separately, because the segmentation part is in the datasets, just download the author’s datasets and follow the command provided by the author to run

Yeah, but I wanna to use it on my dataset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants