-
Notifications
You must be signed in to change notification settings - Fork 77
Conversation
…-backend into solve-issue-837
Codecov Report
@@ Coverage Diff @@
## master #638 +/- ##
=========================================
Coverage ? 95.72%
=========================================
Files ? 362
Lines ? 14071
Branches ? 863
=========================================
Hits ? 13469
Misses ? 484
Partials ? 118
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I see that you found your way into backend and frontend completely on your own - great work! 😄
I went through and made some comments and requested some changes.
Also, could you add another test that fails if the resend was requested too early?
…-backend into solve-issue-837
Hello @tiltec, I made the changes to the code as requested. Hope it's everything alright now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, yeah that's what I had in mid!
I made some more comments, I hope you see the reason for those as well 😄
Oh, I think this branch is quite outdated by now... |
Yes @tiltec I'm still working on it, but this last month has been quite complicated for me, but I'll finish the work hopefully by the end of the week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @tiltec, good evening!
I've addressed all the necessary changes, and I hope everything is okay now! Also, I'd like to apologize for the long delay in finishing my work, these last few months have been wild. I hope to contribute some more from now on.
Best Regards,
Miguel V.
it's not urgent enough to invalidate translations
Frontend PR: karrot-dev/karrot-frontend#1246
Finished the backend part for the issue #837.