Skip to content
This repository has been archived by the owner on May 20, 2024. It is now read-only.

Resend invitation email #638

Merged
merged 19 commits into from
May 21, 2019
Merged

Resend invitation email #638

merged 19 commits into from
May 21, 2019

Conversation

mvellasco
Copy link
Contributor

@mvellasco mvellasco commented Jan 28, 2019

Frontend PR: karrot-dev/karrot-frontend#1246

Finished the backend part for the issue #837.

@codecov
Copy link

codecov bot commented Jan 28, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@b67aefd). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #638   +/-   ##
=========================================
  Coverage          ?   95.72%           
=========================================
  Files             ?      362           
  Lines             ?    14071           
  Branches          ?      863           
=========================================
  Hits              ?    13469           
  Misses            ?      484           
  Partials          ?      118
Impacted Files Coverage Δ
foodsaving/invitations/serializers.py 93.93% <ø> (ø)
foodsaving/invitations/tests/test_api.py 100% <100%> (ø)
foodsaving/invitations/models.py 97.77% <100%> (ø)
foodsaving/invitations/api.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b67aefd...4fab44b. Read the comment docs.

Copy link
Member

@tiltec tiltec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I see that you found your way into backend and frontend completely on your own - great work! 😄

I went through and made some comments and requested some changes.
Also, could you add another test that fails if the resend was requested too early?

foodsaving/invitations/api.py Outdated Show resolved Hide resolved
foodsaving/invitations/serializers.py Outdated Show resolved Hide resolved
foodsaving/invitations/serializers.py Outdated Show resolved Hide resolved
foodsaving/invitations/serializers.py Outdated Show resolved Hide resolved
foodsaving/invitations/serializers.py Outdated Show resolved Hide resolved
@mvellasco
Copy link
Contributor Author

Hello @tiltec, I made the changes to the code as requested. Hope it's everything alright now.

Copy link
Member

@tiltec tiltec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, yeah that's what I had in mid!

I made some more comments, I hope you see the reason for those as well 😄

foodsaving/invitations/api.py Outdated Show resolved Hide resolved
foodsaving/invitations/serializers.py Outdated Show resolved Hide resolved
foodsaving/invitations/api.py Outdated Show resolved Hide resolved
@tiltec
Copy link
Member

tiltec commented Mar 13, 2019

Oh, I think this branch is quite outdated by now...
@mvellasco are you still interested in working on this branch?

@mvellasco
Copy link
Contributor Author

Yes @tiltec I'm still working on it, but this last month has been quite complicated for me, but I'll finish the work hopefully by the end of the week.

@tiltec tiltec changed the title Solved issue #837 WIP: Resend invitation email Apr 27, 2019
Copy link
Contributor Author

@mvellasco mvellasco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @tiltec, good evening!

I've addressed all the necessary changes, and I hope everything is okay now! Also, I'd like to apologize for the long delay in finishing my work, these last few months have been wild. I hope to contribute some more from now on.

Best Regards,
Miguel V.

it's not urgent enough to invalidate translations
@tiltec tiltec changed the title WIP: Resend invitation email Resend invitation email May 21, 2019
@tiltec tiltec merged commit 1563fae into karrot-dev:master May 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants