Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpp code suggestions #2

Closed

Conversation

janoPig
Copy link
Contributor

@janoPig janoPig commented Dec 3, 2023

My code suggestions. They need to be properly tested.

@janoPig janoPig closed this Dec 6, 2023
@janoPig
Copy link
Contributor Author

janoPig commented Dec 6, 2023

not work on linux

@kartelj
Copy link
Owner

kartelj commented Dec 7, 2023

Thanks, I will look onto linux soon. Can you point out the specifics regarding linux installation failure.

Copy link
Owner

@kartelj kartelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems nice.

@janoPig
Copy link
Contributor Author

janoPig commented Dec 7, 2023

Hi, possible fix is in branch https://github.com/janoPig/rils-rols/tree/eigen-included

@janoPig
Copy link
Contributor Author

janoPig commented Dec 7, 2023

I also add repo https://github.com/janoPig/RunSRBench to run SRBench for free with github actions for 4 configurations from 1 second to 5 minutes per fit task. With included eigen source run sucessful also RILS-ROLS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants