Skip to content

Commit

Permalink
Port run by line stepping fix to release (microsoft#12223)
Browse files Browse the repository at this point in the history
* fix continue event to run cell (microsoft#12211)

Co-authored-by: Ian Huff <ianhuff@alex-x230.northamerica.corp.microsoft.com>

* update changelog and delete news file

Co-authored-by: Ian Huff <ianhuff@alex-x230.northamerica.corp.microsoft.com>
  • Loading branch information
IanMatthewHuff and Ian Huff committed Jun 9, 2020
1 parent 22092d9 commit 945d896
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,8 @@
([#12169](https://github.com/Microsoft/vscode-python/issues/12169))
1. Disable `Sort Imports` command in `Notebook Cells`.
([#12193](https://github.com/Microsoft/vscode-python/issues/12193))
1. Fix debugger continue event to actually change a cell.
([#12155](https://github.com/Microsoft/vscode-python/issues/12155))

### Code Health

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -105,18 +105,18 @@ export class NativeEditorRunByLineListener

private async handleStep() {
// User issued a step command.
this.postEmitter.fire({ message: InteractiveWindowMessages.ShowContinue, payload: undefined });
this.postEmitter.fire({ message: InteractiveWindowMessages.ShowContinue, payload: this.currentCellBeingRun });
return this.debugService.step();
}

private async handleContinue() {
// User issued a continue command
this.postEmitter.fire({ message: InteractiveWindowMessages.ShowContinue, payload: undefined });
this.postEmitter.fire({ message: InteractiveWindowMessages.ShowContinue, payload: this.currentCellBeingRun });
return this.debugService.continue();
}

private async handleContinueEvent() {
// Tell the ui to erase the current IP
this.postEmitter.fire({ message: InteractiveWindowMessages.ShowContinue, payload: undefined });
this.postEmitter.fire({ message: InteractiveWindowMessages.ShowContinue, payload: this.currentCellBeingRun });
}
}

0 comments on commit 945d896

Please sign in to comment.