Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Syntax Highlight #5

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

KaanErkol
Copy link

No description provided.

@karthikv
Copy link
Owner

Thanks for the pull request! I'm not sure, however, if CodeMirror is necessary for this project. It seems to add quite a bit of overhead in terms of code, and the results are some basic syntax highlighting, which I don't think adds much to CSS editing. Recall that this code will be inserted into every page the user visits in Chrome, so I'd like to keep the project as succinct as possible. Taking this into account, do you still think CodeMirror is necessary? If so, let me know your reasoning.

If we decide to go through with syntax highlighting, I'll comment on the code in the pull request and let you know what changes are necessary. For starters, you seem to have three duplicate commit messages. Some commits deal with merge conflicts and others appear to modify more files than they actually need to touch. This history will be need to be cleaned up into one commit if we decide to go through with syntax highlighting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants