Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"NaN undefined" shows as file-size if empty file uploaded #894

Closed
pjetherton opened this issue Mar 6, 2017 · 0 comments
Closed

"NaN undefined" shows as file-size if empty file uploaded #894

pjetherton opened this issue Mar 6, 2017 · 0 comments
Labels
enhancement

Comments

@pjetherton
Copy link

Steps to reproduce the issue

Minimal HTML example:

<!DOCTYPE html>
<html>
<head>
  <link href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/css/bootstrap.min.css" rel="stylesheet">
  <!-- Not recommended link for production use; just to demonstrate issue exists in current master -->
  <link href="https://rawgit.com/kartik-v/bootstrap-fileinput/master/css/fileinput.min.css" rel="stylesheet">
</head>
<body>
  <input id="file-input" name="files[]" type="file" multiple>

  <script src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></script>
  <!-- Not recommended link for production use; just to demonstrate issue exists in current master -->
  <script src="https://rawgit.com/kartik-v/bootstrap-fileinput/master/js/fileinput.min.js"></script>
  <script>$(function() { $('#file-input').fileinput({ 'previewFileType': 'any' }); });</script>
</body>
</html>

Upload a 0-byte file.

Expected behavior and actual behavior

(NaN undefined) appears below the filename in the previewer.

I would have expected (0 bytes) to appear instead.

Environment

Browsers

Tested in Chrome on Windows (10).
pjetherton added a commit to pjetherton/bootstrap-fileinput that referenced this issue Mar 6, 2017
@pjetherton
Display file size of empty files correctly
e29f3f7 
Resolves kartik-v#894

0.00 B display is consistent with display of a one byte file (1.00 B) as per the general logic.
@pjetherton pjetherton mentioned this issue Mar 6, 2017
Closed
kartik-v added a commit that referenced this issue Mar 7, 2017
@kartik-v
Updates to release v4.3.9 fix #890 fix #893 fix #894 fix #895
1d47c31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kartik-v @pjetherton