Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Enhancement: Add titles to star elements, like the clear element #111

Closed
davidklebanoff opened this issue Mar 2, 2016 · 1 comment

Comments

@davidklebanoff
Copy link

davidklebanoff commented Mar 2, 2016

Currently the <div class="clear-rating"> element has a title. Now, since we hit 4.x and stars are now there own individual <span class="star"> elements, I think it makes since to add titles to these elements for consistency and added accessibility. The titles either being the values of the starCaptions option, or separate options altogether. Whatever approach is taken, I think it should at least be similar to how the clear button's titles and captions are set.

One possibility is to also merge the clear captions and star captions into something like:

{
    0: 'Clear',
    1: 'One Star',
    2: 'Two Stars',
    3: 'Three Stars',
    4: 'Four Stars',
    5: 'Five Stars'
}

Thoughts?


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@kartik-v
Copy link
Owner

I will look to enhance this - but the clear caption and clear value has to be separate and not mixed with the star captions and values. Note that there is a separate clearValue property for this and it can technically be anything what the developer wants and not necessarily 0 (zero is the default value). For example it can also be a negative number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants