You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the <div class="clear-rating"> element has a title. Now, since we hit 4.x and stars are now there own individual <span class="star"> elements, I think it makes since to add titles to these elements for consistency and added accessibility. The titles either being the values of the starCaptions option, or separate options altogether. Whatever approach is taken, I think it should at least be similar to how the clear button's titles and captions are set.
One possibility is to also merge the clear captions and star captions into something like:
I will look to enhance this - but the clear caption and clear value has to be separate and not mixed with the star captions and values. Note that there is a separate clearValue property for this and it can technically be anything what the developer wants and not necessarily 0 (zero is the default value). For example it can also be a negative number.
Currently the
<div class="clear-rating">
element has a title. Now, since we hit 4.x and stars are now there own individual<span class="star">
elements, I think it makes since to add titles to these elements for consistency and added accessibility. The titles either being the values of the starCaptions option, or separate options altogether. Whatever approach is taken, I think it should at least be similar to how the clear button's titles and captions are set.One possibility is to also merge the clear captions and star captions into something like:
Thoughts?
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: