Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance data hashing and security via a separate helper #205

Closed
16 of 17 tasks
buttflattery opened this issue Sep 3, 2018 · 1 comment
Closed
16 of 17 tasks

Enhance data hashing and security via a separate helper #205

buttflattery opened this issue Sep 3, 2018 · 1 comment

Comments

@buttflattery
Copy link

buttflattery commented Sep 3, 2018

Prerequisites

  • I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
  • The issue still exists against the latest master branch of yii2-tree-manager.
  • This is not a usage question. I confirm having gone through and read the documentation and demos.
  • This is not a general programming/coding question. (Those should be directed to the webtips Q & A forum).
  • I have attempted to find the simplest possible steps to reproduce the issue.
  • I have included a failing test as a pull request (Optional).

Steps to reproduce the issue

1.Install extension
2.customize the view
3.Update the extension to the latest release

Expected behavior and actual behavior

On an update to the latest release, the new $dataToHash which consist of the several items including the
new attributes that were recently added like nodeTitle and nodeTitlePlural should be adjusted accordingly

Actual Behaviour

It throws exception as the signatures dont match and i have to manually copy the new attributes and place them at the exact place they are added in the extensions yii2-tree-manager/views/_form.php file.

Invalid request signature detected during tree data manage action! Please refresh the page and retry.

OLD HASH:
94461115ae4caa395ace47710903879d4ed8665964bb586a226907cefb94d39acommon\models\Campaign111/manage-campaigns@backend/views/campaign/_formnodenodes{"id":"w0-nodeform"}{"1":"","2":"","3":"","4":"","5":""}{"submit":"","reset":" "}"none"{"activeCss":"active","depth":"","glue":" » ","untitled":"Untitled"}
NEW HASH:
3657c070219bec63de1ae8fa39fd1ed212d64816db4d6a4675314f8cd7b31470common\models\Campaign111/manage-campaigns@backend/views/campaign/_formw0-nodeselnodenodes{"id":"w0-nodeform"}{"1":"","2":"","3":"","4":"","5":""}{"submit":"","reset":" "}"none"{"activeCss":"active","depth":"","glue":" » ","untitled":"Untitled"}

Is there a possibility that we convert this form into a widget rather than a view so that the defaults like $dataToHash are automatically adjusted on update if there are additions to it? or maybe anyother way to fix this problem.

Environment

Yii 2.0.15.1
Ubuntu 14.04
Php 7.2

Browsers

  • Google Chrome
  • Mozilla Firefox
  • Internet Explorer
  • Safari

Operating System

  • Windows
  • Mac OS X
  • Linux
  • Mobile

Libraries

  • jQuery version: 2.2.4
  • yii2-tree-manager version: dev-master 8ab3047

Isolating the problem

  • This bug happens on the demos page
  • The bug happens consistently across all tested browsers
  • This bug happens when using yii2-tree-manager without other plugins.
@buttflattery buttflattery changed the title Continious problem whenever the form view is updated with new components Continious problem whenever the form view is updated with new $dataToHash Sep 3, 2018
@buttflattery buttflattery changed the title Continious problem whenever the form view is updated with new $dataToHash Continious problem whenever the form view is updated with new contents for $dataToHash Sep 3, 2018
@kartik-v
Copy link
Owner

This will be enhanced in the upcoming release.

@kartik-v kartik-v changed the title Continious problem whenever the form view is updated with new contents for $dataToHash Enhance data hashing and security via a separate helper Sep 13, 2018
kartik-v added a commit that referenced this issue Sep 13, 2018
kartik-v added a commit that referenced this issue Sep 13, 2018
kartik-v added a commit that referenced this issue Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants