Skip to content
This repository has been archived by the owner on Apr 2, 2019. It is now read-only.

Improve fallback for Chinese languages #23

Merged
merged 2 commits into from
Mar 22, 2019
Merged

Improve fallback for Chinese languages #23

merged 2 commits into from
Mar 22, 2019
+108 −17

Conversation

c933103
Copy link
Contributor

@c933103 c933103 commented Mar 19, 2019 •
edited
Loading

Changes proposed in the patch:

  • add "zh" value as fallback and other relevant fallback according to the current usage of these keys in openstreetmap
  • add Japanese/Korean/Vietnamese han character keys as potential fallback when Chinese name are unavailable

@c933103 c933103 changed the title suggested fix for Chinese name display suggested fix for Chinese name display when Chinese name are unavailable Mar 19, 2019
@c933103 c933103 changed the title suggested fix for Chinese name display when Chinese name are unavailable suggested fix for Chinese name display when the desired key value is unavailable Mar 19, 2019
@c933103 c933103 changed the title suggested fix for Chinese name display when the desired key value is unavailable Improve fallback for Chinese languages Mar 19, 2019
@MaxSem MaxSem mentioned this pull request Mar 19, 2019
Merged
@nyurik
Copy link
Member

nyurik commented Mar 21, 2019 •
edited
Loading

@c933103 there are some build errors with this patch, could you fix them? Looks good otherwise. Thanks!

@nyurik nyurik merged commit 1a13feb into kartotherian:master Mar 22, 2019
@nyurik
Copy link
Member

nyurik commented Mar 22, 2019

Thanks!!

@c933103 c933103 deleted the patch-2 branch June 9, 2020 02:05
@c933103 c933103 mentioned this pull request Jun 9, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c933103 @nyurik