Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix export pdf on metrics #2095

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

danangmassandy
Copy link
Collaborator

@danangmassandy danangmassandy commented Jul 29, 2024

This is for #2078. A naive fix that adds margin height in the canvas.
Generated pdf:
Acinonyx jubatus jubatus - metrics (2).pdf

This fix will not work in data tab because the page is not fixed to 2. I've been trying another lib: https://ekoopmans.github.io/html2pdf.js/ that can support a page break. But the result is not that good either.
Data PDF using current implementation: Acinonyx jubatus jubatus,Loxodonta africana - reports.pdf.

  • Text in row may be splitted
  • Cannot control the page break

Data PDF using html2pdf.js: mydata.pdf.

  • Random row height becomes higher
  • Text in row is not splitted but row height is smaller.
  • Spacing when using page break is not correct.

Copy link

github-actions bot commented Jul 29, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
17061 16559 97% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: b42afa3 by action🐍

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.26%. Comparing base (5ffb9a8) to head (b42afa3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2095      +/-   ##
==========================================
- Coverage   97.26%   97.26%   -0.01%     
==========================================
  Files         375      375              
  Lines       16863    16863              
==========================================
- Hits        16402    16401       -1     
- Misses        461      462       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danangmassandy danangmassandy marked this pull request as ready for review July 29, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant