Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make gloc available for Firefox #23

Closed
Smile4ever opened this issue Mar 22, 2018 · 13 comments
Closed

Make gloc available for Firefox #23

Smile4ever opened this issue Mar 22, 2018 · 13 comments
Assignees
Labels
Milestone

Comments

@Smile4ever
Copy link

No description provided.

@kas-elvirov
Copy link
Owner

Ok. In a few days

@Smile4ever
Copy link
Author

I have installed the extension in Firefox. It works well. I do have some recommendations though:

  • have a separate manifest.json for Firefox, where you replace chrome_style by browser style and add Firefox as a compatible browser, like this
    image

  • either live with the fact that the popup is embedded as options like this:
    image
    and hide the comment about this being a window based on the platform. Documentation here: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/runtime/getPlatformInfo

    • or have a custom HTML file for Firefox, which has a modal popup inside
    • or investigate why it is not working currently

@Smile4ever
Copy link
Author

This addon could be a replacement for https://addons.mozilla.org/en-US/firefox/addon/github-sloc/

@tigattack
Copy link

tigattack commented Feb 22, 2019

What's the current status of this? I'd love to have this for FF.

@kas-elvirov kas-elvirov added the priority Important task label Mar 24, 2019
@Smile4ever
Copy link
Author

@artem-solovev Can you look again at this, please?

@kas-elvirov kas-elvirov added this to the 8.2.0 milestone Nov 23, 2019
@kas-elvirov kas-elvirov modified the milestones: 8.2.0, 8.3.0 Jan 21, 2020
@kas-elvirov kas-elvirov removed this from the 8.3.0 milestone Feb 2, 2020
@suricactus
Copy link

What's the current status of this? I'd love to have this for FF.

@kas-elvirov kas-elvirov added this to the 8.3.0 milestone Mar 19, 2020
@kas-elvirov
Copy link
Owner

@Smile4ever @tigattack @suricactus @btzy
Hi guys. Release will be in this weekends

@kas-elvirov
Copy link
Owner

@Smile4ever @tigattack @suricactus @btzy

So, will be waiting)

image

@kas-elvirov
Copy link
Owner

kas-elvirov commented Mar 22, 2020

Guys, perfecty works (@Smile4ever @tigattack @suricactus @btzy).
App was aproved just now )

Link - https://addons.mozilla.org/en-US/firefox/addon/gloc/

image

@Smile4ever
Copy link
Author

It would be nice to have a screenshot of a specific, opened repository to see the addon working there as well on the Firefox addons page.

@kas-elvirov
Copy link
Owner

@Smile4ever no problem man. I'll make it today) thanks for suggestion, i forgot about that (

@kas-elvirov
Copy link
Owner

@Smile4ever made it. check it out https://addons.mozilla.org/en-GB/firefox/addon/gloc/

@Smile4ever
Copy link
Author

Very good, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants