IRI.pm: Must specify lower bound on regex quantifiers #8
Conversation
There are 5 occurrences of /{,\d}/ in this module. I suspect these were
meant to mean {0,\d}, that is a quantifier matching 0 times up to the
specified limit. But instead Perl thinks they are trying to match a
left brace followed by a comma, followed by the digits, followed by a
right brace. Perl 5.25 now warns about this usage, and so this was
found.
|
Looks good. Thanks for catching this! |
|
Can you point me to where you saw it in Attean? I didn't find anything with a quick grep. |
|
On 06/20/2016 05:37 PM, Gregory Todd Williams wrote:
Thanks for your prompt attention. I investigated, and it appears the http://www.cpantesters.org/cpan/report/ee393738-362c-11e6-83b5-bcf7378fbd9d BTW, this thread on p5p is how I found out about this: |
There are 5 occurrences of /{,\d}/ in this module. I suspect these were
meant to mean {0,\d}, that is a quantifier matching 0 times up to the
specified limit. But instead Perl thinks they are trying to match a
left brace followed by a comma, followed by the digits, followed by a
right brace. Perl 5.25 now warns about this usage, and so this was
found.
It could be that I'm wrong and the code is meant to match that sequence, but it seems unlikely. And if I'm right, it indicates that there are tests missing that would have found this. (The same construct is used as well in Attean.)