Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #13

Merged
merged 5 commits into from
May 26, 2014
Merged

Update README.md #13

merged 5 commits into from
May 26, 2014

Conversation

Jayaramki
Copy link

added code usage of data-showlinenumber and data-showfooter attributes

Jayaramki and others added 3 commits May 13, 2014 18:44
added code usage of data-showlinenumber and data-showfooter attributes
added sample css style for output
add style sheet
@kashif-umair
Copy link
Owner

Hi @Jayaramki,

Thanks for the contribution, but can you please make the following changes in your PR?

Replace data-showlinenumbers with data-showLineNumbers in README.md. Notice the Camel Case letters.

Similiarly replace data-showfooter with data-showFooter.

Thanks,

replaced data-showfooter with data-showFooter and data-showlinenumbers with data-showLinenumbers
replaced data-showLinenumbers with data-showLineNumbers
@Jayaramki
Copy link
Author

yeah... I changed that. Check it now.

@Jayaramki Jayaramki closed this May 23, 2014
@Jayaramki Jayaramki reopened this May 23, 2014
@kashif-umair
Copy link
Owner

Thanks for the contribution. Merging it now :)

kashif-umair added a commit that referenced this pull request May 26, 2014
@kashif-umair kashif-umair merged commit 626272e into kashif-umair:master May 26, 2014
@Jayaramki
Copy link
Author

Thanks...
This is my first contribution to open source project. I'm feeling happy... This is encouraging me to contribute more to open source...
Once again Thanks @kashif-umair

@kashif-umair
Copy link
Owner

Please suggest if you have any ideas to make this plugin better. I'll be happy to help you with that idea and I'll be glad to see your further contribution to this project. Thanks.

@Jayaramki
Copy link
Author

yeah sure @kashif-umair ... If you have free time visit my first repository too. This is about showing rss feed of given url like blogger rss feed widget. But, I gave two additional option to control over feed item count and showing content snippet. https://github.com/Jayaramki/display-feed-js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants