Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow blank address in NotifyUTXOsChanged to get all updates #2027

Merged

Conversation

svarogg
Copy link
Collaborator

@svarogg svarogg commented Apr 17, 2022

No description provided.

@codecov
Copy link

codecov bot commented Apr 17, 2022

Codecov Report

Merging #2027 (1dfb264) into dev (8735da0) will decrease coverage by 0.07%.
The diff coverage is 28.94%.

❗ Current head 1dfb264 differs from pull request most recent head 93af84b. Consider uploading reports for the commit 93af84b to get more accurate results

@@            Coverage Diff             @@
##              dev    #2027      +/-   ##
==========================================
- Coverage   59.48%   59.41%   -0.08%     
==========================================
  Files         673      673              
  Lines       32250    32278      +28     
==========================================
- Hits        19185    19179       -6     
- Misses      10311    10340      +29     
- Partials     2754     2759       +5     
Impacted Files Coverage Δ
domain/consensus/utils/txscript/standard.go 62.26% <0.00%> (ø)
app/rpc/rpccontext/notificationmanager.go 57.54% <27.77%> (-7.68%) ⬇️
app/rpc/rpccontext/context.go 100.00% <100.00%> (ø)
...tructure/network/rpcclient/rpc_on_chain_changed.go 52.38% <0.00%> (-14.29%) ⬇️
infrastructure/network/netadapter/router/route.go 82.85% <0.00%> (-5.72%) ⬇️
...k/netadapter/server/grpcserver/connection_loops.go 56.89% <0.00%> (-5.18%) ⬇️
...ructure/network/rpcclient/grpcclient/grpcclient.go 76.56% <0.00%> (-4.69%) ⬇️
.../protocol/flows/v5/blockrelay/handle_relay_invs.go 53.84% <0.00%> (+1.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8735da0...93af84b. Read the comment docs.

scriptPubKey := utxoindex.ConvertStringToScriptPublicKey(scriptPublicKeyString)
_, address, err := txscript.ExtractScriptPubKeyAddress(scriptPubKey, nl.params)
var addressString string
if err != nil { // This just means the script is not standard
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ExtractScriptPubKeyAddress should just return NonStandardTy for non standard scripts, and no error

@D-Stacks D-Stacks mentioned this pull request May 11, 2022
D-Stacks added a commit to D-Stacks/kaspad that referenced this pull request May 11, 2022
@someone235 someone235 merged commit 5d24e2a into kaspanet:dev May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants