-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow blank address in NotifyUTXOsChanged to get all updates #2027
Allow blank address in NotifyUTXOsChanged to get all updates #2027
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #2027 +/- ##
==========================================
- Coverage 59.48% 59.41% -0.08%
==========================================
Files 673 673
Lines 32250 32278 +28
==========================================
- Hits 19185 19179 -6
- Misses 10311 10340 +29
- Partials 2754 2759 +5
Continue to review full report at Codecov.
|
scriptPubKey := utxoindex.ConvertStringToScriptPublicKey(scriptPublicKeyString) | ||
_, address, err := txscript.ExtractScriptPubKeyAddress(scriptPubKey, nl.params) | ||
var addressString string | ||
if err != nil { // This just means the script is not standard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ExtractScriptPubKeyAddress
should just return NonStandardTy
for non standard scripts, and no error
…in-notify-utxo-changes
No description provided.