Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kaspawallet tracking #2044

Closed
wants to merge 9 commits into from
Closed

Conversation

D-Stacks
Copy link
Contributor

@D-Stacks D-Stacks commented May 11, 2022

draft for wallet tracking,

  1. follow broadcasted transaction ids and wait for acceptance into the DAG, before reusing utxos.
  2. reserving utxos after being used for unsigned transactions.
  3. use Allow blank address in NotifyUTXOsChanged to get all updates #2027 for utxo change updates, instead of calling getutxosbyaddresses each secound.

TO DO:

  1. find a way to query the orphan pool of a mempool.

@D-Stacks D-Stacks changed the base branch from master to dev May 11, 2022 12:50
@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #2044 (27f4cbb) into dev (8735da0) will decrease coverage by 0.30%.
The diff coverage is 3.55%.

❗ Current head 27f4cbb differs from pull request most recent head 290c981. Consider uploading reports for the commit 290c981 to get more accurate results

@@            Coverage Diff             @@
##              dev    #2044      +/-   ##
==========================================
- Coverage   59.48%   59.18%   -0.31%     
==========================================
  Files         673      674       +1     
  Lines       32250    32416     +166     
==========================================
+ Hits        19185    19186       +1     
- Misses      10311    10475     +164     
- Partials     2754     2755       +1     
Impacted Files Coverage Δ
cmd/kaspawallet/daemon/server/balance.go 0.00% <0.00%> (ø)
cmd/kaspawallet/daemon/server/broadcast.go 0.00% <0.00%> (ø)
...allet/daemon/server/create_unsigned_transaction.go 0.00% <0.00%> (ø)
cmd/kaspawallet/daemon/server/server.go 0.00% <0.00%> (ø)
cmd/kaspawallet/daemon/server/split_transaction.go 7.59% <0.00%> (-0.05%) ⬇️
cmd/kaspawallet/daemon/server/sync.go 0.00% <0.00%> (ø)
cmd/kaspawallet/daemon/server/tracker.go 0.00% <0.00%> (ø)
app/rpc/rpccontext/notificationmanager.go 60.09% <26.08%> (-5.12%) ⬇️
app/rpc/rpccontext/context.go 100.00% <100.00%> (ø)
infrastructure/network/netadapter/router/route.go 82.85% <0.00%> (-5.72%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8735da0...290c981. Read the comment docs.

@D-Stacks
Copy link
Contributor Author

Closing: kind of made redunant by #2053 but i suppose i will rework this into two different prs. one for notification updates in the wallet, the other for better / more synced tracking, instead of waiting for 1 minute after broadcasting.

@D-Stacks D-Stacks closed this May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant