Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC: include isSynced and isUtxoIndexed in GetInfoResponse #2068

Merged
merged 5 commits into from
May 30, 2022

Conversation

D-Stacks
Copy link
Contributor

@D-Stacks D-Stacks commented May 30, 2022

this gives more information about a node's state, and allows clients to check if prerequisites are met, prior to its usage.

Espechally useful for filtering public nodes.

@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #2068 (a4f98a9) into dev (440aea1) will increase coverage by 0.02%.
The diff coverage is 84.61%.

❗ Current head a4f98a9 differs from pull request most recent head 9df674b. Consider uploading reports for the commit 9df674b to get more accurate results

@@            Coverage Diff             @@
##              dev    #2068      +/-   ##
==========================================
+ Coverage   59.33%   59.35%   +0.02%     
==========================================
  Files         674      674              
  Lines       32399    32410      +11     
==========================================
+ Hits        19223    19238      +15     
+ Misses      10414    10410       -4     
  Partials     2762     2762              
Impacted Files Coverage Δ
app/rpc/rpchandlers/get_info.go 83.33% <60.00%> (-16.67%) ⬇️
app/appmessage/rpc_get_info.go 100.00% <100.00%> (ø)
...dapter/server/grpcserver/protowire/rpc_get_info.go 72.97% <100.00%> (+3.27%) ⬆️
...k/netadapter/server/grpcserver/connection_loops.go 62.06% <0.00%> (-3.45%) ⬇️
...ructure/network/rpcclient/grpcclient/grpcclient.go 81.25% <0.00%> (+4.68%) ⬆️
app/protocol/flows/v5/blockrelay/block_locator.go 64.70% <0.00%> (+11.76%) ⬆️
...tructure/network/rpcclient/rpc_on_chain_changed.go 66.66% <0.00%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 440aea1...9df674b. Read the comment docs.

michaelsutton
michaelsutton previously approved these changes May 30, 2022
@D-Stacks D-Stacks changed the title RPC: include isNearlySynced and isUtxoindexSet in GetInfoResponse RPC: include isSynced and isUtxoIndexed in GetInfoResponse May 30, 2022
@michaelsutton michaelsutton merged commit 491e356 into kaspanet:dev May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants