Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the time correctness check before starting a node #81

Open
Aleoami opened this issue Nov 18, 2022 · 2 comments
Open

Add the time correctness check before starting a node #81

Aleoami opened this issue Nov 18, 2022 · 2 comments

Comments

@Aleoami
Copy link

Aleoami commented Nov 18, 2022

In order to make nodes have as precise a time as possible and to increase the number of honest nodes reporting a correct time in their blocks, either:

  • check the local time against any available timeserver and refuse to start unless the diff is more than X seconds; ot
  • periodically check the time in the background and simply have a correction value that's added to the local time reports upon necessity, thus having fixed many possible local time issues both deliberately and unknowingly incurred.

Maybe for this purpose implement a time server into the Kaspa DNS servers functionality, to a) decrease the internet time servers load and 2) to increase the chance of having the source of correct time in the case of time servers being firewalled out.

Probably (for a case when there are multiple nodes behind a firewall for redundancy, most of which are only aware of each other, and only 1 of them have the full internet access) also implement a time server functionality into the nodes p2p protocol as a fallback and last resort option.

@D-Stacks
Copy link
Collaborator

D-Stacks commented Nov 19, 2022

I think this is centralization, and can probably be exploited by dns nodes (altering of timestamps) to stop participation. I think dns should just be a one-time entry to collect ips for future node start-ups, to query these.

Perhaps a simple warning, to indicate a possible bad clock, might be okay.

@KaffinPX
Copy link

Thinking same w jwj

1bananagirl pushed a commit to 1bananagirl/rusty-kaspa that referenced this issue Aug 4, 2024
…aspanet#81)

* Kip9 updates to WASM/wallet framework mass calc (kaspanet#66)

* WIP

* update kip9 processing in WASM mass calculator

* XPrv.toPrivateKey support

* replace lazy_static with OnceLock

* remove NetworkParams Inner

* make signatureScript optional on ITransactionInput (WASM32)

* WIP mass calc (WASM32)

* remove WASM32 mass calc, replace with dedicated functions

* use OnceCell for NetworkParams (wallet-core)

* Update changelog

* fmt

---------

Co-authored-by: Surinder Singh Matoo <surinder83singh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants