Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add associated object generator #23

Merged
merged 10 commits into from
May 19, 2024
Merged

Add associated object generator #23

merged 10 commits into from
May 19, 2024

Conversation

kaspth
Copy link
Owner

@kaspth kaspth commented May 14, 2024

Run with:
bin/rails g associated Organization::Seats

Run with:
  `bin/rails g associated Organization::Seats`

Co-authored-by: Garrett Dimon <email@garrettdimon.com>
@kaspth kaspth self-assigned this May 14, 2024
@kaspth
Copy link
Owner Author

kaspth commented May 14, 2024

@garrettdimon thanks for the generator code! I think this is really interesting. I've taken the liberty of tweaking certain names/style to be closer to my mental model.

I've cut the integrating "works with associated object" test since I don't quite understand the need for it — imo that would usually be tested through other behavior in the record itself.

@garrettdimon
Copy link
Contributor

@garrettdimon thanks for the generator code! I think this is really interesting. I've taken the liberty of tweaking certain names/style to be closer to my mental model.

Looks good and much more refined than my first draft. :)

I've cut the integrating "works with associated object" test since I don't quite understand the need for it — imo that would usually be tested through other behavior in the record itself.

Yeah. That was a more whimsical addition that I started on but never quite felt like it was needed and thus never actually took it any further. Definitely agree with cutting it.

@kaspth kaspth merged commit deccb7f into main May 19, 2024
2 checks passed
@kaspth kaspth deleted the add-object-generator branch May 19, 2024 00:05
@natematykiewicz
Copy link
Contributor

This is cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants