Draft: perform index maintenance on repo maintenance #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julio-lopez
force-pushed
the
draft/no-index-cleanup-on-load
branch
from
3dfa75d
to
c6ad13b
Compare
julio-lopez
force-pushed
the
draft/index-maintenance
branch
from
c6386c7
to
d689427
Compare
Shrekster
reviewed
Jan 12, 2024
Comment on lines
+789
to
+794
|
|
||
| if shouldAdvance(cs.UncompactedEpochSets[cs.WriteEpoch], p.MinEpochDuration, p.EpochAdvanceOnCountThreshold, p.EpochAdvanceOnTotalSizeBytesThreshold) { | ||
| return errors.Wrap(e.advanceEpochMarker(ctx, cs), "error advancing epoch") | ||
| } |
There was a problem hiding this comment.
I don't recall this 100%, did we decide that we should advance epoch during maintenance only or that will continue to happen during index loads on write connection ?
In other words, with this change e.allowWrites() will skip epoch advance here by-default now since allowWrites() is going to be returning false always until someone overrides the index manager config from CLI.
There was a problem hiding this comment.
And I just noticed that MaybeAdvanceWriteEpoch() is exposed to be called from maintenance only. That makes sense, but what if maintenance is enabled and e.allowWrites() returns false ? Would that ever happen, if not is that check needed ?
julio-lopez
force-pushed
the
draft/no-index-cleanup-on-load
branch
from
c6ad13b
to
90a0e51
Compare
julio-lopez
force-pushed
the
draft/index-maintenance
branch
from
d689427
to
941d744
Compare
julio-lopez
force-pushed
the
draft/no-index-cleanup-on-load
branch
from
90a0e51
to
c406533
Compare
julio-lopez
force-pushed
the
draft/index-maintenance
branch
from
67984c6
to
b63dac9
Compare
julio-lopez
force-pushed
the
draft/no-index-cleanup-on-load
branch
from
c406533
to
065cf05
Compare
julio-lopez
force-pushed
the
draft/index-maintenance
branch
2 times, most recently
from
fdd22fe
to
19f504d
Compare
julio-lopez
force-pushed
the
draft/no-index-cleanup-on-load
branch
3 times, most recently
from
d4a7004
to
84da027
Compare
julio-lopez
force-pushed
the
draft/index-maintenance
branch
from
19f504d
to
f75914d
Compare
julio-lopez
changed the base branch from
draft/no-index-cleanup-on-load
to
fix/no-index-cleanup-on-load-env-var
julio-lopez
force-pushed
the
draft/index-maintenance
branch
from
f75914d
to
8f98f4e
Compare
|
Closing in favor of the upstream PR kopia#3651 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Early draft with partial implementation