refactor(general): perform index compaction during repo maintenance #3651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julio-lopez
added
performance
enterprise
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3651 +/- ##
==========================================
+ Coverage 75.86% 77.09% +1.22%
==========================================
Files 470 476 +6
Lines 37301 28902 -8399
==========================================
- Hits 28299 22281 -6018
+ Misses 7071 4693 -2378
+ Partials 1931 1928 -3 ☔ View full report in Codecov by Sentry. |
julio-lopez
changed the title
6 tasks
julio-lopez
force-pushed
the
fix/epoch-maintenance
branch
3 times, most recently
from
c133f9a
to
d1d670f
Compare
plar
reviewed
Feb 29, 2024
julio-lopez
commented
Mar 1, 2024
| TaskIndexCompaction = "index-compaction" | ||
| TaskExtendBlobRetentionTimeFull = "extend-blob-retention-time" | ||
| TaskCleanupLogs = "cleanup-logs" | ||
| TaskEpochDeleteSupersededIndexes = "delete-superseded-epoch-indexes" |
There was a problem hiding this comment.
Other "epoch" cleanup tasks are added as well
internal/epoch/epoch_manager.go
Outdated
| @@ -593,19 +593,28 @@ func (e *Manager) loadSingleEpochCompactions(ctx context.Context, cs *CurrentSna | |||
| return nil | |||
| } | |||
|
|
|||
| func (e *Manager) maybeGenerateNextRangeCheckpointAsync(ctx context.Context, cs CurrentSnapshot, p *Parameters) { | |||
| func getRangeToCompact(cs CurrentSnapshot, p Parameters) (low, high int, compactRange bool) { | |||
There was a problem hiding this comment.
This is "factored out" from maybeGenerateNextRangeCheckpointAsync
It is reused.
plar
reviewed
Mar 1, 2024
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
redgoat650
approved these changes
Mar 1, 2024
julio-lopez
commented
Mar 2, 2024
julio-lopez
added a commit
to kastenhq/kopia
that referenced
this pull request
Mar 6, 2024
julio-lopez
added a commit
to kastenhq/kopia
that referenced
this pull request
Mar 7, 2024
julio-lopez
added a commit
that referenced
this pull request
Mar 7, 2024
julio-lopez
added a commit
to kastenhq/kopia
that referenced
this pull request
Mar 12, 2024
Extracted from kopia#3651. Thanks to @plar and @redgoat650 for the suggestions. Ref: - kopia#3603 - kopia#3645 - kopia#3638 - kopia#3639
julio-lopez
added a commit
that referenced
this pull request
Mar 12, 2024
julio-lopez
force-pushed
the
fix/epoch-maintenance
branch
2 times, most recently
from
a9e21c7
to
ab2c592
Compare
This was referenced Mar 19, 2024
julio-lopez
added a commit
that referenced
this pull request
Mar 20, 2024
Add: - epoch.Manager.MaybeCompactSingleEpoch - getCompactedEpochRange helper - oldestUncompactedEpoch helper - TestOldestUncompactedEpoch - Tests for MaybeCompactSingleEpoch Ref: - Subset and dependency of #3651 - Depends on #3735 - Avoid index (epoch) cleanup and compaction during index reads #3638 - Make "read" commands/operations really read-only. #3639
julio-lopez
force-pushed
the
fix/epoch-maintenance
branch
from
ab2c592
to
0b1d208
Compare
julio-lopez
force-pushed
the
fix/epoch-maintenance
branch
from
0b1d208
to
f95d675
Compare
julio-lopez
force-pushed
the
fix/epoch-maintenance
branch
from
f95d675
to
1115325
Compare
julio-lopez
force-pushed
the
fix/epoch-maintenance
branch
from
1115325
to
9f33ef8
Compare
julio-lopez
force-pushed
the
fix/epoch-maintenance
branch
from
9f33ef8
to
f4b88af
Compare
redgoat650
approved these changes
Mar 27, 2024
|
|
||
| // compact range | ||
| if err := ReportRun(ctx, runParams.rep, TaskEpochGenerateRange, s, func() error { | ||
| log(ctx).Infof("Attempting to compact a range of epoch indexes ...") |
There was a problem hiding this comment.
super nit: the other similar info logs have no space before the ellipsis. Remove for consistency?
Suggested change
| log(ctx).Infof("Attempting to compact a range of epoch indexes ...") | |
| log(ctx).Infof("Attempting to compact a range of epoch indexes...") |
Lyndon-Li
pushed a commit
to Lyndon-Li/kopia
that referenced
this pull request
Mar 29, 2024
…opia#3651) Perform index epoch compaction and cleanup during repository maintenance * refactor: rename maintenance task for deleting superseded indexes * maintenance task to cleanup epoch markers * maintenance task to advance write index epoch * maintenance task to compact epoch ranges * quick maintenance task to compact a single (index) epoch * full maintenance task to compact a single (index) epoch Ref: - kopia#3638 - kopia#3639 Followup to: - kopia#3603 - kopia#3645 Related helpers and changes: - kopia#3721 - kopia#3735 - kopia#3709 - kopia#3728 - kopia#3727 - kopia#3726
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perform index epoch compaction and cleanup during repository maintenance.
Ref:
Followup to:
Related helpers and changes: