fix(cli): ScrubSensitiveData to scrub recursively #537
Conversation
Shrekster
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #537 +/- ##
==========================================
- Coverage 75.86% 75.84% -0.03%
==========================================
Files 465 465
Lines 37171 37179 +8
==========================================
- Hits 28201 28197 -4
- Misses 7047 7053 +6
- Partials 1923 1929 +6 ☔ View full report in Codecov by Sentry. |
| @@ -12,7 +12,11 @@ import ( | |||
| type S struct { | |||
| SomePassword1 string `kopia:"sensitive"` | |||
| NonPassword string | |||
| Inner *Q | |||
| InnerPtr *Q | |||
There was a problem hiding this comment.
Does extending the struct cover the desired cases? or should the text be extended with additional "input cases"?
There was a problem hiding this comment.
I initially started writing a table driven test with inputs and expected outputs, but concluded it was a lot of boilerplate to accomplish the same conditions: instead of defining different test structs for the different test cases we could get the same coverage by adding the newly-handled field types in the existing test struct.
No description provided.