fix(cli): Ensure scrubber checks all fields recursively for sensitive tags #3589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redgoat650
requested review from
jkowalski,
julio-lopez,
pavannd1 and
Shrekster
redgoat650
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3589 +/- ##
==========================================
+ Coverage 75.80% 75.82% +0.02%
==========================================
Files 465 465
Lines 37171 37182 +11
==========================================
+ Hits 28177 28193 +16
+ Misses 7063 7057 -6
- Partials 1931 1932 +1 ☔ View full report in Codecov by Sentry. |
Shrekster
approved these changes
Jan 26, 2024
julio-lopez
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add recursive checks to ensure that sub-structures with sensitive fields also get scrubbed by
ScrubSensitiveData.