Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix "Cannot read property 'riskcode' of undefined" #28

Merged
merged 7 commits into from
Aug 27, 2019

Conversation

insideou7
Copy link
Contributor

Fixes the following:

#27
#25
#21
#16
#12

@andydkelly
Copy link

Any ideas when we can see this pull request merged?

@izvictor
Copy link

Hello,
We are currently having the same issue, when are you planing to merge the request ?

@kasunkv
Copy link
Owner

kasunkv commented Feb 8, 2019

@insideou7 @izvictor I will work on getting this PRs merged and a new version released by the end of the weekend. I need to do some changes to the CI pipeline and how I release these new versions. I will work on that during the weekend. Sorry for the delay.

@andydkelly-ig
Copy link

Thanks @kasunkv appreciate you getting back to us. Looking forward to the fix 👍

@jodachecallan
Copy link

@kasunkv Any progress on getting this PR complete?

@kasunkv
Copy link
Owner

kasunkv commented Feb 21, 2019

@insideou7 Thanks for the contribution :) Finally got some time to setup the CI process for the repo. Can you please update this branch with the current changes to the master branch and update the PR. Then I will approve and get a version released. Sorry for the delay in response.

@insideou7
Copy link
Contributor Author

insideou7 commented Feb 21, 2019

Done. One problem though- my change is for what the JS needs to be, I don't know what the TS needs to be to compile to it. This is my first time using TS.

Copy link
Owner

@kasunkv kasunkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@kasunkv kasunkv merged commit ed590a8 into kasunkv:master Aug 27, 2019
@insideou7 insideou7 deleted the FixAlertIteration branch September 30, 2019 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants