Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

docs: Make dev guide prefer vanilla qemu to qemu-lite #68

Conversation

jodh-intel
Copy link
Contributor

Updated the developer guide to explain that vanilla qemu is now the
preferred hypervisor rather than the qemu-lite package used for Clear
Containers.

Also, provided a pointer to the versions database to allow developers to see the range of golang versions known to work.

Fixes #67.

Signed-off-by: James O. D. Hunt james.o.hunt@intel.com

Provide a pointer to the versions database to allow developers
to see the range of golang versions known to work.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
@jodh-intel jodh-intel force-pushed the update-dev-guide-for-vanilla-qemu branch 3 times, most recently from 6442a45 to e9cd710 Compare May 9, 2018 11:24
Updated the developer guide to explain that vanilla qemu is now the
preferred hypervisor rather than the `qemu-lite` package used for Clear
Containers.

Fixes kata-containers#67.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
@jodh-intel jodh-intel force-pushed the update-dev-guide-for-vanilla-qemu branch from e9cd710 to c402617 Compare May 9, 2018 11:27
@jodh-intel
Copy link
Contributor Author

Hi @egernst, @klynnrif, @gnodli - please take a look.

@egernst
Copy link
Member

egernst commented May 9, 2018

I think the default we want is still -lite, and the config should reflect this by default.

@jodh-intel
Copy link
Contributor Author

The build default change was done on kata-containers/runtime#119. There is some discussion there but of course we did merge the change. I can close this PR or modify it to state the following maybe?

  • if you want maximum boot speed and memory density, you should consider qemu-lite.
  • if you'd rather stick with a vanilla qemu, use the distro-packaged version.

Copy link

@klynnrif klynnrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completed scrub for grammar, flow, and structure - two minor changes suggested here. Thanks!

- `make`.
- `gcc` (required for building the shim and runtime).
- `qemu` version 2.11 or newer.

Note that `qemu` version 2.10 may also work but will not perform as well
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that qemu version 2.10 might also work but will not perform as well


https://github.com/clearcontainers/runtime/wiki/Installation

However, note that the use of `qemu-lite` is deprecated in favour of
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest replacing "favour" with "favor": @jodh-intel maybe we should have @rcaballeromx make a call on whether we go with American or British English as a rule for instances moving ahead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

American English! :)

@egernst
Copy link
Member

egernst commented May 15, 2018

@jodh-intel should we close this PR, or?

@jodh-intel
Copy link
Contributor Author

I think so yes. To summarise:

Closing this PR but I'll raise another to explain that discrepancy to devs...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants