-
Notifications
You must be signed in to change notification settings - Fork 303
docs: Make dev guide prefer vanilla qemu to qemu-lite #68
docs: Make dev guide prefer vanilla qemu to qemu-lite #68
Conversation
Provide a pointer to the versions database to allow developers to see the range of golang versions known to work. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
6442a45
to
e9cd710
Compare
Updated the developer guide to explain that vanilla qemu is now the preferred hypervisor rather than the `qemu-lite` package used for Clear Containers. Fixes kata-containers#67. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
e9cd710
to
c402617
Compare
I think the default we want is still -lite, and the config should reflect this by default. |
The build default change was done on kata-containers/runtime#119. There is some discussion there but of course we did merge the change. I can close this PR or modify it to state the following maybe?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Completed scrub for grammar, flow, and structure - two minor changes suggested here. Thanks!
- `make`. | ||
- `gcc` (required for building the shim and runtime). | ||
- `qemu` version 2.11 or newer. | ||
|
||
Note that `qemu` version 2.10 may also work but will not perform as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that qemu
version 2.10 might also work but will not perform as well
|
||
https://github.com/clearcontainers/runtime/wiki/Installation | ||
|
||
However, note that the use of `qemu-lite` is deprecated in favour of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest replacing "favour" with "favor": @jodh-intel maybe we should have @rcaballeromx make a call on whether we go with American or British English as a rule for instances moving ahead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
American English! :)
@jodh-intel should we close this PR, or? |
I think so yes. To summarise:
Closing this PR but I'll raise another to explain that discrepancy to devs... |
Updated the developer guide to explain that vanilla qemu is now the
preferred hypervisor rather than the
qemu-lite
package used for ClearContainers.
Also, provided a pointer to the versions database to allow developers to see the range of golang versions known to work.
Fixes #67.
Signed-off-by: James O. D. Hunt james.o.hunt@intel.com