Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

install: Fix kata installation steps. #83

Merged
merged 1 commit into from May 19, 2018

Conversation

jcvenegas
Copy link
Member

Fix kata installation URL.

@jodh-intel
Copy link
Contributor

Hi @jcvenegas - I'm afraid we don't want to do this. Everything should be using https now. I think you've been hit by the same proxy problem as @eadamsintel had on #61.

@jodh-intel jodh-intel requested review from jodh-intel and removed request for jodh-intel May 15, 2018 14:59
@jodh-intel
Copy link
Contributor

(ftr, it works perfectly using https without proxies ;)

@egernst
Copy link
Member

egernst commented May 15, 2018

@jodh-intel I ran into this issue on an external (cloud) machine. No proxy.

@jodh-intel
Copy link
Contributor

It sounds like this is a package version issue. I tested with Ubuntu 17.10. We really want to avoid having to document an insecure installation method using http though.

@chavafg
Copy link
Contributor

chavafg commented May 15, 2018

https does not work for me when installing under Ubuntu 16.04.

@jcvenegas
Copy link
Member Author

hey @jodh-intel thanks for the clarification, I was thinking was a general issue - and wanted not having our docs broken. So if is only for a few of us - lets debug a bit more.

@egernst
Copy link
Member

egernst commented May 15, 2018

@jcvenegas I think this is xenial specific. Perhaps just a short term w/a necessary while we still package Xenial?

@jodh-intel
Copy link
Contributor

I've recreated the problem on Ubuntu 16.04. In fact, you can simulate it in any environment like this by telling curl to allow redirects but only to another https url:

$ curl -sSL --proto \=https --proto-redir \=https -O https://download.opensuse.org/repositories/home:/katacontainers:/release/xUbuntu_16.04/./amd64/qemu-vanilla_2.11+git.e3050471ff-35_amd64.deb  
curl: (1) Protocol "http" not supported or disabled in libcurl

The problem is that the opensuse download site appears to be redirecting the incoming https request to an http download url, even though the connection originally came in via https. If correct, that seems rather broken to me.

What's odd is that the opensuse download site can service https downloads fwics. Adding curl debug (-vvv) shows that after the https -> http redirect, the actual file that will be downloaded is:

And yet, you can download that file over https!:

$ curl -L --proto \=https --proto-redir \=https -O https://downloadcontent.opensuse.org/repositories/home:/katacontainers:/release/xUbuntu_16.04/amd64/qemu-vanilla_2.11+git.e3050471ff-35_amd64.deb

Hence, I think this issue can be summarised as "Ubuntu 16.04 is dtrt wrt security but the opensuse server appears to be 'not configured optimally', atleast for libcurl clients ;-)".

Unless opensuse change their server configuration, I think we are indeed going to be forced into changing the urls to "http" for two reasons:

  1. To allow the Ubuntu 16.04 to actually work.
  2. To make it clear to all users installing Kata that this is an insecure download
    (since even if you specify https urls, they get rewritten to http silently by newer distro versions).

/cc @cseader.

@egernst
Copy link
Member

egernst commented May 17, 2018

@jodh-intel based on this; this PR shouldn't be "do not merge" at this point, right?

@jodh-intel
Copy link
Contributor

Well, imho we need to:

  • also revert the fedora install doc to specify http since if you see my comments above even though OBS supports https URLs, they appear to redirect to http. That's bad from a security standpoint.
  • add warnings to both docs that the installation method is insecure due to OBS's servers.

@egernst
Copy link
Member

egernst commented May 17, 2018

@ajaeger - FYI.

@jcvenegas jcvenegas force-pushed the fix-ubuntu-docs branch 3 times, most recently from a3e2f87 to 17c4314 Compare May 17, 2018 15:34
@jodh-intel
Copy link
Contributor

jodh-intel commented May 18, 2018

Hi @jcvenegas - it appears obs still has the problem so...

lgtm

(You need to rebase though).

Approved with PullApprove Approved with PullApprove

obs provides ubuntu packages by http not https.

Fixes: kata-containers#81

Signed-off-by: Jose Carlos Venegas Munoz <jose.carlos.venegas.munoz@intel.com>
@jcvenegas
Copy link
Member Author

hum odd travis fail.

$ ruby --version
ruby 2.4.1p111 (2017-03-22 revision 58053) [x86_64-linux]
$ rvm --version
rvm 1.29.3 (latest) by Michal Papis, Piotr Kuczynski, Wayne E. Seguin [https://rvm.io]
$ bundle --version
Bundler version 1.16.2
$ gem --version
2.7.7
0.16s$ rake
rake aborted!
No Rakefile found (looking for: rakefile, Rakefile, rakefile.rb, Rakefile.rb)
/home/travis/.rvm/gems/ruby-2.4.1@global/gems/rake-12.3.0/exe/rake:27:in `<top (required)>'
(See full trace by running task with --trace)

Not a blocker

@egernst egernst merged commit a019574 into kata-containers:master May 19, 2018
@jodh-intel
Copy link
Contributor

Hi @vrothberg - could you provide any further details on the https -> http issue mentioned above (#83 (comment))?

@vrothberg
Copy link

vrothberg commented Jun 5, 2018

@jodh-intel Thanks for reaching out! I will make sure our build team has a look at the issue.

@jodh-intel
Copy link
Contributor

@vrothberg - no problem and thanks! 😄

@jodh-intel
Copy link
Contributor

@vrothberg, @adrianschroeter - I've checked this morning and the https -> http issue seems to be mostly resolved so thanks for fixing this this!

However, a random sampling of downloads for https://download.opensuse.org/repositories/home:/katacontainers:/release/ shows that the only distros where we are unable to download entirely via https are... OpenSUSE and SLES:

$  curl -sS -L --proto \=https --proto-redir \=https -O https://download.opensuse.org/repositories/home:/katacontainers:/release/openSUSE_Leap_42.3/x86_64/kata-linux-container-debug-4.14.51.1-132.1.x86_64.rpm
curl: (1) Protocol "http" not supported or disabled in libcurl
$ curl -sS -L --proto \=https --proto-redir \=https -O https://download.opensuse.org/repositories/home:/katacontainers:/release/SLE_12_SP3/x86_64/kata-proxy-1.1.0+git.8a305e5-30.1.x86_64.rpm
curl: (1) Protocol "http" not supported or disabled in libcurl

Could you tweak the settings for those repos too please?

@marcov
Copy link
Contributor

marcov commented Sep 27, 2018

Hi @jodh-intel, not all the mirrors in the mirror infrastructure supports HTTPS. That's also why the .repo includes URL with HTTP and not HTTPS.

But as I explained here HTTP is not an issue, and in my view the warning should be removed from the doc pages.

(Speaking for SUSE) Probably you can safely use HTTPS as the main repo URL, but individual packages will still be downloaded using HTTP.

devimc pushed a commit to devimc/kata-documentation that referenced this pull request Sep 2, 2019
…file

refactor and create a summary file inside the image
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants