This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Add support for hot-plugging IBM Adjunct Processor (AP) devices #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I already reviewed @Jakob-Naucke's PR. This is LGTM for me. |
jodh-intel
approved these changes
Aug 12, 2020
|
GoVMM's Travis succeeded (somehow not visible in GitHub yet?) and the re-vendoring tests in Kata succeeded except for two that always seem to fail recently (see PR #496 and issue #505 in Kata). @jodh-intel @devimc would you rather wait for one or both of them to be fixed or do you think this could be merged? |
|
@Jakob-Naucke travis is very unstable, I restarted the job and now it's failing (sorry for that), I raised a PR to fix it (#137) but I'm also working to rid of travis and use github actions. |
|
@Jakob-Naucke please rebase this, you will need this change #137 |
Add ExecuteAPVFIOMediatedDeviceAdd to qmp.go, which executes a hotplug for an IBM Adjunct processor (AP) VFIO device (see also https://www.kernel.org/doc/html/latest/s390/vfio-ap.html ) Also includes the respective unittest and adds the VfioAP DeviceDriver constant to qemu.go. Pushing again due to incidental CI failure Fixes: #133 Signed-off-by: Jakob-Naucke <jakob.naucke@ibm.com> Reviewed-by: alicefr <afrosi@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
ExecuteAPVFIOMediatedDeviceAddtoqemu/qmp.go, which executes a hot-plug for an IBM Adjunct Processor (AP) VFIO device (kernel doc here).See also Issue #491 in the Kata Containers project.
/cc @alicefr
Fixes: #133
If this LGTY in general, I'd create a Do-Not-Merge re-vendoring PR in Kata first to ensure compatibility.