Skip to content

Commit

Permalink
config: Add better comments in the template files
Browse files Browse the repository at this point in the history
When there is a default value from the code (usually empty) that
differs from a possible suggested value from the distro, then the
wording "default: empty" is confusing.

Fixes: #901

Suggested-by: Julio Montes <julio.montes@intel.com>
Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
  • Loading branch information
c3d committed Oct 14, 2020
1 parent 7c6aede commit d65a7d1
Show file tree
Hide file tree
Showing 5 changed files with 47 additions and 17 deletions.
8 changes: 6 additions & 2 deletions src/runtime/cli/config/configuration-acrn.toml.in
Expand Up @@ -21,11 +21,15 @@ image = "@IMAGEPATH@"
# of the annotation, e.g. "path" for io.katacontainers.config.hypervisor.path"
enable_annotations = @DEFENABLEANNOTATIONS@

# List of valid annotations values for the hypervisor (default: empty)
# List of valid annotations values for the hypervisor
# Each member of the list is a path pattern as described by glob(3).
# The default if not set is empty (all annotations rejected.)
# Your distribution recommends: @ACRNPATHLIST@
path_list = @ACRNPATHLIST@

# List of valid annotations values for ctlpath (default: empty)
# List of valid annotations values for ctlpath
# The default if not set is empty (all annotations rejected.)
# Your distribution recommends: @ACRNCTLPATHLIST@
ctlpath_list = @ACRNCTLPATHLIST@

# Optional space-separated list of options to pass to the guest kernel.
Expand Down
8 changes: 6 additions & 2 deletions src/runtime/cli/config/configuration-clh.toml.in
Expand Up @@ -20,8 +20,10 @@ image = "@IMAGEPATH@"
# of the annotation, e.g. "path" for io.katacontainers.config.hypervisor.path"
enable_annotations = @DEFENABLEANNOTATIONS@

# List of valid annotations values for the hypervisor (default: empty)
# List of valid annotations values for the hypervisor
# Each member of the list is a path pattern as described by glob(3).
# The default if not set is empty (all annotations rejected.)
# Your distribution recommends: @CLHPATHLIST@
path_list = @CLHPATHLIST@

# Optional space-separated list of options to pass to the guest kernel.
Expand Down Expand Up @@ -71,7 +73,9 @@ default_memory = @DEFMEMSZ@
# Path to vhost-user-fs daemon.
virtio_fs_daemon = "@DEFVIRTIOFSDAEMON@"

# List of valid annotations values for the virtiofs daemon (default: empty)
# List of valid annotations values for the virtiofs daemon
# The default if not set is empty (all annotations rejected.)
# Your distribution recommends: @DEFVIRTIOFSDAEMONLIST@
virtio_fs_daemon_list = @DEFVIRTIOFSDAEMONLIST@

# Default size of DAX cache in MiB
Expand Down
10 changes: 7 additions & 3 deletions src/runtime/cli/config/configuration-fc.toml.in
Expand Up @@ -20,8 +20,10 @@ image = "@IMAGEPATH@"
# of the annotation, e.g. "path" for io.katacontainers.config.hypervisor.path"
enable_annotations = @DEFENABLEANNOTATIONS@

# List of valid annotations values for the hypervisor (default: empty)
# List of valid annotations values for the hypervisor
# Each member of the list is a path pattern as described by glob(3).
# The default if not set is empty (all annotations rejected.)
# Your distribution recommends: @FCPATHLIST@
path_list = @FCPATHLIST@

# Path for the jailer specific to firecracker
Expand All @@ -32,9 +34,11 @@ path_list = @FCPATHLIST@
# for this feature today.
#jailer_path = "@FCJAILERPATH@"

# List of valid jailer path values for the hypervisor (default: empty)
# List of valid jailer path values for the hypervisor
# Each member of the list can be a regular expression
# jailer_path_list = @FCJAILERPATHLIST@
# The default if not set is empty (all annotations rejected.)
# Your distribution recommends: @FCJAILERPATHLIST@
jailer_path_list = @FCJAILERPATHLIST@


# Optional space-separated list of options to pass to the guest kernel.
Expand Down
20 changes: 15 additions & 5 deletions src/runtime/cli/config/configuration-qemu-virtiofs.toml.in
Expand Up @@ -19,10 +19,14 @@ machine_type = "@MACHINETYPE@"
# List of valid annotation names for the hypervisor
# Each member of the list is a regular expression, which is the base name
# of the annotation, e.g. "path" for io.katacontainers.config.hypervisor.path"
# The default if not set is empty (all annotations rejected.)
# Your distribution recommends: @DEFENABLEANNOTATIONS@
enable_annotations = @DEFENABLEANNOTATIONS@

# List of valid annotations values for the hypervisor (default: empty)
# List of valid annotations values for the hypervisor
# Each member of the list is a path pattern as described by glob(3).
# The default if not set is empty (all annotations rejected.)
# Your distribution recommends: @QEMUVIRTIOFSPATHLIST@
path_list = @QEMUVIRTIOFSPATHLIST@

# Optional space-separated list of options to pass to the guest kernel.
Expand Down Expand Up @@ -119,7 +123,9 @@ shared_fs = "@DEFSHAREDFS_QEMU_VIRTIOFS@"
# Path to vhost-user-fs daemon.
virtio_fs_daemon = "@DEFVIRTIOFSDAEMON@"

# List of valid annotations values for the virtiofs daemon (default: empty)
# List of valid annotations values for the virtiofs daemon
# The default if not set is empty (all annotations rejected.)
# Your distribution recommends: @DEFVIRTIOFSDAEMONLIST@
virtio_fs_daemon_list = @DEFVIRTIOFSDAEMONLIST@

# Default size of DAX cache in MiB
Expand Down Expand Up @@ -211,7 +217,9 @@ vhost_user_store_path = "@DEFVHOSTUSERSTOREPATH@"
# Enabling this will result in the VM device having iommu_platform=on set
#enable_iommu_platform = true

# List of valid annotations values for the virtiofs daemon (default: empty)
# List of valid annotations values for the virtiofs daemon
# The default if not set is empty (all annotations rejected.)
# Your distribution recommends: @DEFVHOSTUSERSTOREPATHLIST@
vhost_user_store_path_list = @DEFVHOSTUSERSTOREPATHLIST@

# Enable file based guest memory support. The default is an empty string which
Expand All @@ -220,8 +228,10 @@ vhost_user_store_path_list = @DEFVHOSTUSERSTOREPATHLIST@
# This option will be ignored if VM templating is enabled.
#file_mem_backend = "@DEFFILEMEMBACKEND@"

# List of valid annotations values for the file_mem_backend annotation (default: empty)
#file_mem_backend_list = @DEFFILEMEMBACKENDLIST@
# List of valid annotations values for the file_mem_backend annotation
# The default if not set is empty (all annotations rejected.)
# Your distribution recommends: @DEFFILEMEMBACKENDLIST@
file_mem_backend_list = @DEFFILEMEMBACKENDLIST@

# Enable swap of vm memory. Default false.
# The behaviour is undefined if mem_prealloc is also set to true
Expand Down
18 changes: 13 additions & 5 deletions src/runtime/cli/config/configuration-qemu.toml.in
Expand Up @@ -21,8 +21,10 @@ machine_type = "@MACHINETYPE@"
# of the annotation, e.g. "path" for io.katacontainers.config.hypervisor.path"
enable_annotations = @DEFENABLEANNOTATIONS@

# List of valid annotations values for the hypervisor (default: empty)
# List of valid annotations values for the hypervisor
# Each member of the list is a path pattern as described by glob(3).
# The default if not set is empty (all annotations rejected.)
# Your distribution recommends: @QEMUPATHLIST@
path_list = @QEMUPATHLIST@

# Optional space-separated list of options to pass to the guest kernel.
Expand Down Expand Up @@ -125,7 +127,9 @@ shared_fs = "@DEFSHAREDFS@"
# Path to vhost-user-fs daemon.
virtio_fs_daemon = "@DEFVIRTIOFSDAEMON@"

# List of valid annotations values for the virtiofs daemon (default: empty)
# List of valid annotations values for the virtiofs daemon
# The default if not set is empty (all annotations rejected.)
# Your distribution recommends: @DEFVIRTIOFSDAEMONLIST@
virtio_fs_daemon_list = @DEFVIRTIOFSDAEMONLIST@

# Default size of DAX cache in MiB
Expand Down Expand Up @@ -217,7 +221,9 @@ vhost_user_store_path = "@DEFVHOSTUSERSTOREPATH@"
# Enabling this will result in the VM device having iommu_platform=on set
#enable_iommu_platform = true

# List of valid annotations values for the vhost user store path (default: empty)
# List of valid annotations values for the vhost user store path
# The default if not set is empty (all annotations rejected.)
# Your distribution recommends: @DEFVHOSTUSERSTOREPATHLIST@
vhost_user_store_path_list = @DEFVHOSTUSERSTOREPATHLIST@

# Enable file based guest memory support. The default is an empty string which
Expand All @@ -226,8 +232,10 @@ vhost_user_store_path_list = @DEFVHOSTUSERSTOREPATHLIST@
# This option will be ignored if VM templating is enabled.
#file_mem_backend = "@DEFFILEMEMBACKEND@"

# List of valid annotations values for the file_mem_backend annotation (default: empty)
#file_mem_backend_list = @DEFFILEMEMBACKENDLIST@
# List of valid annotations values for the file_mem_backend annotation
# The default if not set is empty (all annotations rejected.)
# Your distribution recommends: @DEFFILEMEMBACKENDLIST@
file_mem_backend_list = @DEFFILEMEMBACKENDLIST@

# Enable swap of vm memory. Default false.
# The behaviour is undefined if mem_prealloc is also set to true
Expand Down

0 comments on commit d65a7d1

Please sign in to comment.