Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generation of firecracker config #1001

Closed
jodh-intel opened this issue Oct 20, 2020 · 0 comments · Fixed by #1002
Closed

Fix generation of firecracker config #1001

jodh-intel opened this issue Oct 20, 2020 · 0 comments · Fixed by #1002
Assignees
@jodh-intel
Labels
bug Incorrect behaviour
Projects
Issue backlog

Comments

@jodh-intel
Copy link
Contributor

jodh-intel commented Oct 20, 2020 •
edited

PR #902 reworked the code that generates the hypervisor configuration, but we didn't catch a problem: the FCVALIDPATHS variable is set, but never referenced by configuration-fc.toml. The configuration file is actually expecting to be passed a FCVALIDHYPERVISORPATHS variable but that is never set resulting in the following in configuration-fc.toml:

valid_hypervisor_paths =

The impact is that you cannot run a firecracker container until you change your configuration-fc.toml file to specify:

valid_hypervisor_paths = ["/opt/kata/bin/firecracker"]
@jodh-intel jodh-intel added bug Incorrect behaviour needs-review Needs to be assessed by the team. labels Oct 20, 2020
@jodh-intel jodh-intel self-assigned this Oct 20, 2020
@jodh-intel jodh-intel removed the needs-review Needs to be assessed by the team. label Oct 20, 2020
@jodh-intel jodh-intel added this to To do in Issue backlog Oct 20, 2020
jodh-intel added a commit to jodh-intel/kata-containers that referenced this issue Oct 20, 2020
@jodh-intel
runtime: Fix firecracker config
2738b18 
The build was setting a `FCVALIDPATHS` variable for firecracker, but
that was never being used. Conversely, the firecracker configuration
template was expecting a `FCVALIDHYPERVISORPATHS`, but that variable was
never being set.

Resolve by only setting the `FCVALIDHYPERVISORPATHS` variable to ensure
the generated firecracker config is valid once again.

Fixes: kata-containers#1001.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
@jodh-intel jodh-intel mentioned this issue Oct 20, 2020
Merged
@jodh-intel jodh-intel moved this from To do to In progress in Issue backlog Oct 20, 2020
c3d pushed a commit to c3d/runtime that referenced this issue Oct 20, 2020
@jodh-intel @c3d
runtime: Fix firecracker config
06b4ab9 
The build was setting a `FCVALIDPATHS` variable for firecracker, but
that was never being used. Conversely, the firecracker configuration
template was expecting a `FCVALIDHYPERVISORPATHS`, but that variable was
never being set.

Resolve by only setting the `FCVALIDHYPERVISORPATHS` variable to ensure
the generated firecracker config is valid once again.

Fixes: kata-containers#3005

From kata-containers/kata-containers#1002
Fixing kata-containers/kata-containers#1001

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
c3d pushed a commit to c3d/runtime that referenced this issue Oct 21, 2020
@jodh-intel @c3d
runtime: Fix firecracker config
32283c8 
The build was setting a `FCVALIDPATHS` variable for firecracker, but
that was never being used. Conversely, the firecracker configuration
template was expecting a `FCVALIDHYPERVISORPATHS`, but that variable was
never being set.

Resolve by only setting the `FCVALIDHYPERVISORPATHS` variable to ensure
the generated firecracker config is valid once again.

Fixes: kata-containers#3005

From kata-containers/kata-containers#1002
Fixing kata-containers/kata-containers#1001

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
c3d pushed a commit to c3d/runtime that referenced this issue Oct 22, 2020
@jodh-intel @c3d
runtime: Fix firecracker config
0d8dfc4 
The build was setting a `FCVALIDPATHS` variable for firecracker, but
that was never being used. Conversely, the firecracker configuration
template was expecting a `FCVALIDHYPERVISORPATHS`, but that variable was
never being set.

Resolve by only setting the `FCVALIDHYPERVISORPATHS` variable to ensure
the generated firecracker config is valid once again.

Fixes: kata-containers#3005

From kata-containers/kata-containers#1002
Fixing kata-containers/kata-containers#1001

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
Issue backlog automation moved this from In progress to Done Oct 23, 2020
c3d pushed a commit to c3d/runtime that referenced this issue Oct 27, 2020
@jodh-intel @c3d
runtime: Fix firecracker config
4dcc464 
The build was setting a `FCVALIDPATHS` variable for firecracker, but
that was never being used. Conversely, the firecracker configuration
template was expecting a `FCVALIDHYPERVISORPATHS`, but that variable was
never being set.

Resolve by only setting the `FCVALIDHYPERVISORPATHS` variable to ensure
the generated firecracker config is valid once again.

Fixes: kata-containers#3005

From kata-containers/kata-containers#1002
Fixing kata-containers/kata-containers#1001

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
c3d pushed a commit to c3d/runtime that referenced this issue Nov 5, 2020
@jodh-intel @c3d
runtime: Fix firecracker config
e1f792c 
The build was setting a `FCVALIDPATHS` variable for firecracker, but
that was never being used. Conversely, the firecracker configuration
template was expecting a `FCVALIDHYPERVISORPATHS`, but that variable was
never being set.

Resolve by only setting the `FCVALIDHYPERVISORPATHS` variable to ensure
the generated firecracker config is valid once again.

Fixes: kata-containers#3005

From kata-containers/kata-containers#1002
Fixing kata-containers/kata-containers#1001

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
c3d pushed a commit to c3d/runtime that referenced this issue Nov 10, 2020
@jodh-intel @c3d
runtime: Fix firecracker config
90ff89e 
The build was setting a `FCVALIDPATHS` variable for firecracker, but
that was never being used. Conversely, the firecracker configuration
template was expecting a `FCVALIDHYPERVISORPATHS`, but that variable was
never being set.

Resolve by only setting the `FCVALIDHYPERVISORPATHS` variable to ensure
the generated firecracker config is valid once again.

Fixes: kata-containers#3005

From kata-containers/kata-containers#1002
Fixing kata-containers/kata-containers#1001

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
fidencio pushed a commit to fidencio/kata-runtime that referenced this issue Nov 11, 2020
@jodh-intel @fidencio
runtime: Fix firecracker config
ff869d5 
The build was setting a `FCVALIDPATHS` variable for firecracker, but
that was never being used. Conversely, the firecracker configuration
template was expecting a `FCVALIDHYPERVISORPATHS`, but that variable was
never being set.

Resolve by only setting the `FCVALIDHYPERVISORPATHS` variable to ensure
the generated firecracker config is valid once again.

Fixes: kata-containers#3005

From kata-containers/kata-containers#1002
Fixing kata-containers/kata-containers#1001

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
fidencio pushed a commit to fidencio/kata-runtime that referenced this issue Nov 11, 2020
@jodh-intel @fidencio
runtime: Fix firecracker config
14bb5f1 
The build was setting a `FCVALIDPATHS` variable for firecracker, but
that was never being used. Conversely, the firecracker configuration
template was expecting a `FCVALIDHYPERVISORPATHS`, but that variable was
never being set.

Resolve by only setting the `FCVALIDHYPERVISORPATHS` variable to ensure
the generated firecracker config is valid once again.

Fixes: kata-containers#3005

From kata-containers/kata-containers#1002
Fixing kata-containers/kata-containers#1001

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
c3d pushed a commit that referenced this issue Apr 12, 2021
@jodh-intel @c3d
runtime: Fix firecracker config
5b6c477 
The build was setting a `FCVALIDPATHS` variable for firecracker, but
that was never being used. Conversely, the firecracker configuration
template was expecting a `FCVALIDHYPERVISORPATHS`, but that variable was
never being set.

Resolve by only setting the `FCVALIDHYPERVISORPATHS` variable to ensure
the generated firecracker config is valid once again.

Fixes: #1001.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
c3d pushed a commit to c3d/kata-containers that referenced this issue Apr 12, 2021
@jodh-intel @c3d
runtime: Fix firecracker config
6261645 
The build was setting a `FCVALIDPATHS` variable for firecracker, but
that was never being used. Conversely, the firecracker configuration
template was expecting a `FCVALIDHYPERVISORPATHS`, but that variable was
never being set.

Resolve by only setting the `FCVALIDHYPERVISORPATHS` variable to ensure
the generated firecracker config is valid once again.

Fixes: kata-containers#1001.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodh-intel jodh-intel

Labels
bug Incorrect behaviour
Projects
Issue backlog
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

runtime: Fix firecracker config jodh-intel/kata-containers
1 participant
@jodh-intel