Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libs: logging: Fix logger #8546

Closed
jodh-intel opened this issue Dec 1, 2023 · 0 comments · Fixed by #8547
Closed

libs: logging: Fix logger #8546

jodh-intel opened this issue Dec 1, 2023 · 0 comments · Fixed by #8547
Assignees
@jodh-intel
Labels
area/logging Logging bug Incorrect behaviour highest-priority Critically urgent issue (must be resolved as soon as possible) rust Pull requests that update Rust code
Projects
Issue backlog

Comments

@jodh-intel
Copy link
Contributor

It appears that #8311 inadvertently broke the logging: with that PR, no messages below Info are logged.
@jodh-intel jodh-intel added bug Incorrect behaviour highest-priority Critically urgent issue (must be resolved as soon as possible) area/logging Logging rust Pull requests that update Rust code labels Dec 1, 2023
@jodh-intel jodh-intel self-assigned this Dec 1, 2023
jodh-intel added a commit to jodh-intel/kata-containers that referenced this issue Dec 1, 2023
@jodh-intel
libs:logging: Fix logger
f9f1d3a 
PR kata-containers#8311 inadvertently broke the logging since no log messages below the
`Info` level are logged now, regardless of the requested log level.

Resolve the issue by storing the requested log level in the
`RuntimeComponentLevelFilter` and using that level in the `log()`
function, rather than hard-coding `Info` as the default where no entry
is found in the `FILTER_RULE` hashmap.

Fixes: kata-containers#8546.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
@jodh-intel jodh-intel mentioned this issue Dec 1, 2023
Merged
@katacontainersbot katacontainersbot moved this from To do to In progress in Issue backlog Dec 1, 2023
sprt pushed a commit to microsoft/kata-containers that referenced this issue Dec 20, 2023
@jodh-intel @sprt
libs:logging: Fix logger
25d7d86 
PR kata-containers#8311 inadvertently broke the logging since no log messages below the
`Info` level are logged now, regardless of the requested log level.

Resolve the issue by storing the requested log level in the
`RuntimeComponentLevelFilter` and using that level in the `log()`
function, rather than hard-coding `Info` as the default where no entry
is found in the `FILTER_RULE` hashmap.

Fixes: kata-containers#8546.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
sprt pushed a commit to microsoft/kata-containers that referenced this issue Dec 20, 2023
@jodh-intel @sprt
libs:logging: Fix logger
6841ce9 
PR kata-containers#8311 inadvertently broke the logging since no log messages below the
`Info` level are logged now, regardless of the requested log level.

Resolve the issue by storing the requested log level in the
`RuntimeComponentLevelFilter` and using that level in the `log()`
function, rather than hard-coding `Info` as the default where no entry
is found in the `FILTER_RULE` hashmap.

Fixes: kata-containers#8546.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
sprt pushed a commit to microsoft/kata-containers that referenced this issue Dec 20, 2023
@jodh-intel @sprt
libs:logging: Fix logger
7be99cc 
PR kata-containers#8311 inadvertently broke the logging since no log messages below the
`Info` level are logged now, regardless of the requested log level.

Resolve the issue by storing the requested log level in the
`RuntimeComponentLevelFilter` and using that level in the `log()`
function, rather than hard-coding `Info` as the default where no entry
is found in the `FILTER_RULE` hashmap.

Fixes: kata-containers#8546.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
sprt pushed a commit to microsoft/kata-containers that referenced this issue Dec 20, 2023
@jodh-intel @sprt
libs:logging: Fix logger
a11be83 
PR kata-containers#8311 inadvertently broke the logging since no log messages below the
`Info` level are logged now, regardless of the requested log level.

Resolve the issue by storing the requested log level in the
`RuntimeComponentLevelFilter` and using that level in the `log()`
function, rather than hard-coding `Info` as the default where no entry
is found in the `FILTER_RULE` hashmap.

Fixes: kata-containers#8546.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodh-intel jodh-intel

Labels
area/logging Logging bug Incorrect behaviour highest-priority Critically urgent issue (must be resolved as soon as possible) rust Pull requests that update Rust code
Projects
Issue backlog
  
In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

libs:logging: Fix logger jodh-intel/kata-containers
1 participant
@jodh-intel