libs:logging: Fix logger #8547
libs:logging: Fix logger #8547
Conversation
PR kata-containers#8311 inadvertently broke the logging since no log messages below the `Info` level are logged now, regardless of the requested log level. Resolve the issue by storing the requested log level in the `RuntimeComponentLevelFilter` and using that level in the `log()` function, rather than hard-coding `Info` as the default where no entry is found in the `FILTER_RULE` hashmap. Fixes: kata-containers#8546. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
|
It's worth noting that the logger tests were failing. We need to find a way to re-introduce the changes I added on #2970 in a reliable way. Part of the problem is that our build system doesn't currently distinguish between golang and rust components. If it did, we could make all rust components depend on running the logger test suite before building the component. But that's not reliable as developers can in some instances just run Another approach would be to have a rust "build script" that we add to all rust components to force-run the logger tests. That would involve duplication though. |
|
This PR will need to go into the next release. |
jodh-intel
added
safe-to-test
|
/test |
|
#8554 raised to address the issue of re-enabling the feature where we always run the logger tests (always, I say! ;) |
PR #8311 inadvertently broke the logging since no log messages below the
Infolevel are logged now, regardless of the requested log level.Resolve the issue by storing the requested log level in the
RuntimeComponentLevelFilterand using that level in thelog()function, rather than hard-codingInfoas the default where no entry is found in theFILTER_RULEhashmap.Fixes: #8546.
Signed-off-by: James O. D. Hunt james.o.hunt@intel.com