Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

genpolicy: refactor counter-intuitive -i flag #8568

Closed
katexochen opened this issue Dec 5, 2023 · 0 comments · Fixed by #8941
Closed

genpolicy: refactor counter-intuitive -i flag #8568

katexochen opened this issue Dec 5, 2023 · 0 comments · Fixed by #8941
Labels
enhancement Improvement to an existing feature needs-review Needs to be assessed by the team.
Projects
Issue backlog

Comments

@katexochen
Copy link

Which feature do you think can be improved?

genpolicy tool

How can it be improved?

The semantics of the genpolicy -i flag are quite counter-intuitive. As a user, I would like to place these files independently from each other in the place I like.This could be implement this as -r flag to directly point to the rego policy instead of having the -i flag to specify a path prefix that affects other options.

See previous discussion in #8248 (comment)

Before raising this enhancement request

Have you looked at the limitations document?
@katexochen katexochen added enhancement Improvement to an existing feature needs-review Needs to be assessed by the team. labels Dec 5, 2023
@malt3 malt3 mentioned this issue Jan 11, 2024
Merged
@malt3 malt3 mentioned this issue Jan 29, 2024
Merged
@katacontainersbot katacontainersbot moved this from To do to In progress in Issue backlog Jan 29, 2024
danmihai1 pushed a commit to microsoft/kata-containers that referenced this issue Feb 1, 2024
@malt3 @danmihai1
genpolicy: allow separate paths for rules and settings files
6d688c1 
Using custom input paths with -i is counter-intuitive. Simplify path handling with explicit flags for rules.rego and genpolicy-settings.json.

Fixes: kata-containers#8568

Signed-Off-By: Malte Poll <1780588+malt3@users.noreply.github.com>
c3d pushed a commit to c3d/kata-containers that referenced this issue Feb 23, 2024
@malt3 @c3d
genpolicy: allow separate paths for rules and settings files
c2fdf99 
Using custom input paths with -i is counter-intuitive. Simplify path handling with explicit flags for rules.rego and genpolicy-settings.json.

Fixes: kata-containers#8568

Signed-Off-By: Malte Poll <1780588+malt3@users.noreply.github.com>
Redent0r pushed a commit to microsoft/kata-containers that referenced this issue Apr 8, 2024
@malt3 @Redent0r
genpolicy: allow separate paths for rules and settings files
98c5af6 
Using custom input paths with -i is counter-intuitive. Simplify path handling with explicit flags for rules.rego and genpolicy-settings.json.

Fixes: kata-containers#8568

Signed-Off-By: Malte Poll <1780588+malt3@users.noreply.github.com>
Redent0r pushed a commit to microsoft/kata-containers that referenced this issue Apr 9, 2024
@malt3 @Redent0r
genpolicy: allow separate paths for rules and settings files
c608826 
Using custom input paths with -i is counter-intuitive. Simplify path handling with explicit flags for rules.rego and genpolicy-settings.json.

Fixes: kata-containers#8568

Signed-Off-By: Malte Poll <1780588+malt3@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement to an existing feature needs-review Needs to be assessed by the team.
Projects
Issue backlog
  
In progress
Policy
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

genpolicy: allow separate paths for rules and settings files
1 participant
@katexochen