New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hook up migrated static checks to GHA #8595

Closed

cmaf opened this issue Dec 6, 2023 · 0 comments · Fixed by #8635

Assignees

Labels

Projects

Contributor

cmaf commented Dec 6, 2023

In #8288, static checks and dependencies were copied to the main repo and modified to run from that repo (tested locally). The next step is to add it to GHA. After this static checks in the tests repo will be obsolete.

cmaf added enhancement needs-review and removed needs-review labels

katacontainersbot added this to To do in Issue backlog

cmaf mentioned this issue

CI: static-checks: Try multiple user agents #8592

Merged

cmaf self-assigned this

This was referenced Dec 6, 2023

kata-ctl: Moved log-parser-rs into kata-ctl #6826

Merged

CI: Make URL checker use a list of user agents kata-containers/tests#5800

Closed

static-checks: Try multiple user agents kata-containers/tests#5801

Merged

cmaf added a commit to cmaf/kata-containers that referenced this issue


          static-checks: Fix directory for github labels

790723d

Fix paths for yqdir (where the install_yq.sh script currently is) so
that static checks can run without error.

Fixes kata-containers#8595

Signed-off-by: Chelsea Mafrica <chelsea.e.mafrica@intel.com>

cmaf added a commit to cmaf/kata-containers that referenced this issue


          static-checks: Direct Makefile to use new static checks

4d6488e

Direct the Makefile to use the static checks script in the tests
directory of the main Kata Containers repo so that when GHA runs make
static-checks the new migrated script is used.

Remove the old static checks script and the function in lib.sh that
uses the test repo.

Fixes kata-containers#8595

Signed-off-by: Chelsea Mafrica <chelsea.e.mafrica@intel.com>

cmaf added a commit to cmaf/kata-containers that referenced this issue


          static-checks: Change dir for building tools

c7573db

Change directory for running make due to local errors when building with
make -C.

Fixes kata-containers#8595

Signed-off-by: Chelsea Mafrica <chelsea.e.mafrica@intel.com>

cmaf mentioned this issue

static-checks: Direct Makefile to use new static checks #8635

Merged

katacontainersbot moved this from To do to In progress in Issue backlog

cmaf added a commit to cmaf/kata-containers that referenced this issue


          static-checks: Fix directory for github labels

a9d3607

Fix paths for yqdir (where the install_yq.sh script currently is) so
that static checks can run without error.

Fixes kata-containers#8595

Signed-off-by: Chelsea Mafrica <chelsea.e.mafrica@intel.com>

cmaf added a commit to cmaf/kata-containers that referenced this issue


          static-checks: Direct Makefile to use new static checks

68063f5

Direct the Makefile to use the static checks script in the tests
directory of the main Kata Containers repo so that when GHA runs make
static-checks the new migrated script is used.

Remove the old static checks script and the function in lib.sh that
uses the test repo.

Fixes kata-containers#8595

Signed-off-by: Chelsea Mafrica <chelsea.e.mafrica@intel.com>

cmaf added a commit to cmaf/kata-containers that referenced this issue


          static-checks: Change dir for building tools

be2f909

Change directory for running make due to local errors when building with
make -C.

Fixes kata-containers#8595

Signed-off-by: Chelsea Mafrica <chelsea.e.mafrica@intel.com>

cmaf added a commit to cmaf/kata-containers that referenced this issue


          static-checks: Update copyright dates

5b6d530

Some copyright dates were not updated with the most recent changes to
code; update them.

Fixes kata-containers#8595

Signed-off-by: Chelsea Mafrica <chelsea.e.mafrica@intel.com>

cmaf added a commit to cmaf/kata-containers that referenced this issue


          static-checks: Change dir for building tools

b11c772

Change directory for running make due to local errors when building with
make -C.

Fixes kata-containers#8595

Signed-off-by: Chelsea Mafrica <chelsea.e.mafrica@intel.com>

cmaf added a commit to cmaf/kata-containers that referenced this issue


          static-checks: Update copyright dates

63636b8

Some copyright dates were not updated with the most recent changes to
code; update them.

Fixes kata-containers#8595

Signed-off-by: Chelsea Mafrica <chelsea.e.mafrica@intel.com>

cmaf added a commit to cmaf/kata-containers that referenced this issue


          static-checks: Direct Makefile to use new static checks

b46cb22

Direct the Makefile to use the static checks script in the tests
directory of the main Kata Containers repo so it is run in GHA.

Fixes kata-containers#8595

Signed-off-by: Chelsea Mafrica <chelsea.e.mafrica@intel.com>

cmaf closed this as completed in #8635

sprt pushed a commit to microsoft/kata-containers that referenced this issue


          static-checks: Fix directory for github labels

c56491a

Fix paths for yqdir (where the install_yq.sh script currently is) so
that static checks can run without error.

Fixes kata-containers#8595

Signed-off-by: Chelsea Mafrica <chelsea.e.mafrica@intel.com>

sprt pushed a commit to microsoft/kata-containers that referenced this issue


          static-checks: Change dir for building tools

d53436f

Change directory for running make due to local errors when building with
make -C.

Fixes kata-containers#8595

Signed-off-by: Chelsea Mafrica <chelsea.e.mafrica@intel.com>

sprt pushed a commit to microsoft/kata-containers that referenced this issue


          static-checks: Update copyright dates

fa20a8d

Some copyright dates were not updated with the most recent changes to
code; update them.

Fixes kata-containers#8595

Signed-off-by: Chelsea Mafrica <chelsea.e.mafrica@intel.com>

sprt pushed a commit to microsoft/kata-containers that referenced this issue


          static-checks: Direct Makefile to use new static checks

72fed7b

Direct the Makefile to use the static checks script in the tests
directory of the main Kata Containers repo so it is run in GHA.

Fixes kata-containers#8595

Signed-off-by: Chelsea Mafrica <chelsea.e.mafrica@intel.com>

sprt pushed a commit to microsoft/kata-containers that referenced this issue


          static-checks: Fix directory for github labels

9f68d2d

Fix paths for yqdir (where the install_yq.sh script currently is) so
that static checks can run without error.

Fixes kata-containers#8595

Signed-off-by: Chelsea Mafrica <chelsea.e.mafrica@intel.com>

sprt pushed a commit to microsoft/kata-containers that referenced this issue


          static-checks: Change dir for building tools

ddd042e

Change directory for running make due to local errors when building with
make -C.

Fixes kata-containers#8595

Signed-off-by: Chelsea Mafrica <chelsea.e.mafrica@intel.com>

sprt pushed a commit to microsoft/kata-containers that referenced this issue


          static-checks: Update copyright dates

61a31af

Some copyright dates were not updated with the most recent changes to
code; update them.

Fixes kata-containers#8595

Signed-off-by: Chelsea Mafrica <chelsea.e.mafrica@intel.com>

sprt pushed a commit to microsoft/kata-containers that referenced this issue


          static-checks: Direct Makefile to use new static checks

c3e025b

Direct the Makefile to use the static checks script in the tests
directory of the main Kata Containers repo so it is run in GHA.

Fixes kata-containers#8595

Signed-off-by: Chelsea Mafrica <chelsea.e.mafrica@intel.com>

sprt pushed a commit to microsoft/kata-containers that referenced this issue


          static-checks: Fix directory for github labels

9b31f89

Fix paths for yqdir (where the install_yq.sh script currently is) so
that static checks can run without error.

Fixes kata-containers#8595

Signed-off-by: Chelsea Mafrica <chelsea.e.mafrica@intel.com>

sprt pushed a commit to microsoft/kata-containers that referenced this issue


          static-checks: Change dir for building tools

a3ce016

Change directory for running make due to local errors when building with
make -C.

Fixes kata-containers#8595

Signed-off-by: Chelsea Mafrica <chelsea.e.mafrica@intel.com>

sprt pushed a commit to microsoft/kata-containers that referenced this issue


          static-checks: Update copyright dates

1797e88

Some copyright dates were not updated with the most recent changes to
code; update them.

Fixes kata-containers#8595

Signed-off-by: Chelsea Mafrica <chelsea.e.mafrica@intel.com>

sprt pushed a commit to microsoft/kata-containers that referenced this issue


          static-checks: Direct Makefile to use new static checks

b62de51

Direct the Makefile to use the static checks script in the tests
directory of the main Kata Containers repo so it is run in GHA.

Fixes kata-containers#8595

Signed-off-by: Chelsea Mafrica <chelsea.e.mafrica@intel.com>

sprt pushed a commit to microsoft/kata-containers that referenced this issue


          static-checks: Fix directory for github labels

1744e2a

Fix paths for yqdir (where the install_yq.sh script currently is) so
that static checks can run without error.

Fixes kata-containers#8595

Signed-off-by: Chelsea Mafrica <chelsea.e.mafrica@intel.com>

sprt pushed a commit to microsoft/kata-containers that referenced this issue


          static-checks: Change dir for building tools

71be5c9

Change directory for running make due to local errors when building with
make -C.

Fixes kata-containers#8595

Signed-off-by: Chelsea Mafrica <chelsea.e.mafrica@intel.com>

sprt pushed a commit to microsoft/kata-containers that referenced this issue


          static-checks: Update copyright dates

e0e5630

Some copyright dates were not updated with the most recent changes to
code; update them.

Fixes kata-containers#8595

Signed-off-by: Chelsea Mafrica <chelsea.e.mafrica@intel.com>

sprt pushed a commit to microsoft/kata-containers that referenced this issue


          static-checks: Direct Makefile to use new static checks

7eedbac

Direct the Makefile to use the static checks script in the tests
directory of the main Kata Containers repo so it is run in GHA.

Fixes kata-containers#8595

Signed-off-by: Chelsea Mafrica <chelsea.e.mafrica@intel.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment