static-checks: Direct Makefile to use new static checks #8635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please hold off on merging before I run some local tests tomorrow. |
Fix paths for yqdir (where the install_yq.sh script currently is) so that static checks can run without error. Fixes kata-containers#8595 Signed-off-by: Chelsea Mafrica <chelsea.e.mafrica@intel.com>
cmaf
force-pushed
the
migrate-static-checks-gha
branch
from
c7573db
to
be2f909
Compare
katacontainersbot
added
size/small
cmaf
force-pushed
the
migrate-static-checks-gha
branch
from
540840d
to
5b6d530
Compare
cmaf
added
safe-to-test
katacontainersbot
added
size/small
amshinde
approved these changes
Dec 12, 2023
Change directory for running make due to local errors when building with make -C. Fixes kata-containers#8595 Signed-off-by: Chelsea Mafrica <chelsea.e.mafrica@intel.com>
Some copyright dates were not updated with the most recent changes to code; update them. Fixes kata-containers#8595 Signed-off-by: Chelsea Mafrica <chelsea.e.mafrica@intel.com>
Direct the Makefile to use the static checks script in the tests directory of the main Kata Containers repo so it is run in GHA. Fixes kata-containers#8595 Signed-off-by: Chelsea Mafrica <chelsea.e.mafrica@intel.com>
cmaf
force-pushed
the
migrate-static-checks-gha
branch
from
5b6d530
to
b46cb22
Compare
|
Will remove the function in lib.sh and the ci/static-checks.sh script in a follow-up PR since some other scripts unrelated to GHA still point to them. This is a follow up to #8288 |
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Direct the Makefile to use the static checks script in the tests directory of the main Kata Containers repo so that when GHA runs make static-checks the new migrated script is used.
Remove the old static checks script and the function in lib.sh that uses the test repo.
Fixes #8595
Signed-off-by: Chelsea Mafrica chelsea.e.mafrica@intel.com