Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA: Missing a secret inheritance for build-kata-static-tarball-s390x #8611

Closed
BbolroC opened this issue Dec 8, 2023 · 0 comments · Fixed by #8612
Closed

GHA: Missing a secret inheritance for build-kata-static-tarball-s390x #8611

BbolroC opened this issue Dec 8, 2023 · 0 comments · Fixed by #8612
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.

Comments

@BbolroC
Copy link
Member

BbolroC commented Dec 8, 2023

Description of problem

For a workflow CI | Build kata-static tarball for s390x, the secret inheritance is missing. This leads to a build failure at a step build-asset-boot-image-se due to lack of an environment variable CI_HKD_PATH like:

Run mkdir -p "host-key-document"
  mkdir -p "host-key-document"
  cp "${CI_HKD_PATH}" "host-key-document"
  shell: /usr/bin/bash -e {0}
  env:
    CI_HKD_PATH: 
cp: cannot stat '': No such file or directory

It should have been like:

Run mkdir -p "host-key-document"
  mkdir -p "host-key-document"
  cp "${CI_HKD_PATH}" "host-key-document"
  shell: /usr/bin/bash -e {0}
  env:
    CI_HKD_PATH: 
cp: cannot stat '': No such file or directory

We should add secrets: inherit for all steps which includes the workflow build-kata-static-tarball-s390x.yaml.

@BbolroC BbolroC added bug Incorrect behaviour needs-review Needs to be assessed by the team. labels Dec 8, 2023
BbolroC added a commit to BbolroC/kata-containers that referenced this issue Dec 8, 2023
This is to make GHA secrets inherited for the workflow titled
`build-kata-static-tarball-s390x` to configure an environment
variable `CI_HKD_PATH` for a `build-asset-boot-image-se` step.

Fixes: kata-containers#8611

Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
@katacontainersbot katacontainersbot moved this from To do to In progress in Issue backlog Dec 8, 2023
BbolroC added a commit to BbolroC/kata-containers that referenced this issue Dec 8, 2023
This is to make GHA secrets inherited for the workflow titled
`build-kata-static-tarball-s390x` to configure an environment
variable `CI_HKD_PATH` for a `build-asset-boot-image-se` step.

Fixes: kata-containers#8611

Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
BbolroC added a commit to BbolroC/kata-containers that referenced this issue Dec 8, 2023
This is to make GHA secrets inherited for the workflow titled
`build-kata-static-tarball-s390x` to configure an environment
variable `CI_HKD_PATH` for a `build-asset-boot-image-se` step.

Fixes: kata-containers#8611

Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
sprt pushed a commit to microsoft/kata-containers that referenced this issue Dec 20, 2023
This is to make GHA secrets inherited for the workflow titled
`build-kata-static-tarball-s390x` to configure an environment
variable `CI_HKD_PATH` for a `build-asset-boot-image-se` step.

Fixes: kata-containers#8611

Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
sprt pushed a commit to microsoft/kata-containers that referenced this issue Dec 20, 2023
This is to make GHA secrets inherited for the workflow titled
`build-kata-static-tarball-s390x` to configure an environment
variable `CI_HKD_PATH` for a `build-asset-boot-image-se` step.

Fixes: kata-containers#8611

Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
sprt pushed a commit to microsoft/kata-containers that referenced this issue Dec 20, 2023
This is to make GHA secrets inherited for the workflow titled
`build-kata-static-tarball-s390x` to configure an environment
variable `CI_HKD_PATH` for a `build-asset-boot-image-se` step.

Fixes: kata-containers#8611

Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
sprt pushed a commit to microsoft/kata-containers that referenced this issue Dec 20, 2023
This is to make GHA secrets inherited for the workflow titled
`build-kata-static-tarball-s390x` to configure an environment
variable `CI_HKD_PATH` for a `build-asset-boot-image-se` step.

Fixes: kata-containers#8611

Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.
Projects
Issue backlog
  
In progress
Development

Successfully merging a pull request may close this issue.

1 participant