Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA: make secrets inherited for build-kata-static-tarball-s390x #8612

Merged

Conversation

BbolroC
Copy link
Member

@BbolroC BbolroC commented Dec 8, 2023

This is to make GHA secrets inherited for the workflow titled build-kata-static-tarball-s390x to configure an environment variable CI_HKD_PATH for a build-asset-boot-image-se step.

Fixes: #8611

Signed-off-by: Hyounggyu Choi Hyounggyu.Choi@ibm.com

@katacontainersbot katacontainersbot added the size/tiny Smallest and simplest task label Dec 8, 2023
@BbolroC BbolroC force-pushed the introduce-secret-inheritance-s390x branch from ef71eca to 670362a Compare December 8, 2023 12:48
This is to make GHA secrets inherited for the workflow titled
`build-kata-static-tarball-s390x` to configure an environment
variable `CI_HKD_PATH` for a `build-asset-boot-image-se` step.

Fixes: kata-containers#8611

Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
@BbolroC BbolroC force-pushed the introduce-secret-inheritance-s390x branch from 670362a to 636eef8 Compare December 8, 2023 12:55
Copy link
Contributor

@wainersm wainersm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensuring that build-kata-static-tarball-s390x.yaml inherit the secrets from the caller workflow should fix the problem. Thanks @BbolroC !

@BbolroC
Copy link
Member Author

BbolroC commented Dec 8, 2023

/test

@BbolroC
Copy link
Member Author

BbolroC commented Dec 8, 2023

I've verified the change at https://github.com/BbolroC/kata-containers/actions/runs/7142606557/job/19453773493 and it worked out.

@BbolroC
Copy link
Member Author

BbolroC commented Dec 8, 2023

/test

@zvonkok zvonkok merged commit 9d38f01 into kata-containers:main Dec 8, 2023
160 of 174 checks passed
@BbolroC BbolroC deleted the introduce-secret-inheritance-s390x branch December 8, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test size/tiny Smallest and simplest task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GHA: Missing a secret inheritance for build-kata-static-tarball-s390x
6 participants