Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Physical network interfaces passed in the network interface are not returned to original driver in case of failure. #8646

Closed
amshinde opened this issue Dec 13, 2023 · 0 comments · Fixed by #8647
Closed

Physical network interfaces passed in the network interface are not returned to original driver in case of failure. #8646

amshinde opened this issue Dec 13, 2023 · 0 comments · Fixed by #8647
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.
Projects
Issue backlog

Comments

@amshinde
Copy link
Member

I am currently testing with SRIOV CNI + device plugin. I am seeing some failures that need to be debugged. But I am seeing that in case the runtime errors out the sriov virtual function passed in the network namespace by the CNI remains bound to vfio-pci.
Since the runtime binds the network interface to vfio-pci from host driver, in case of error the interface needs to be reassigned to the host driver during network cleanup, which is not happening currently.
@amshinde amshinde added bug Incorrect behaviour needs-review Needs to be assessed by the team. labels Dec 13, 2023
amshinde added a commit to amshinde/kata-containers that referenced this issue Dec 13, 2023
@amshinde
network: Move up defer block tp cleanup network
10723a0 
Move the defer for cleaning up network before the call to add network.
This way if any change made by add network is reverted by in case of
failure. This is particulary important for physical network interfaces
as with this step we make sure that driver for the physical interface is
reverted back to the original host driver. Without this the physical
network iterface will remain bound to vfio.

Fixes: kata-containers#8646

Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
@amshinde amshinde mentioned this issue Dec 13, 2023
Merged
@katacontainersbot katacontainersbot moved this from To do to In progress in Issue backlog Dec 13, 2023
amshinde added a commit to amshinde/kata-containers that referenced this issue Feb 8, 2024
@amshinde
network: Move up defer block tp cleanup network
24f5e87 
Move the defer for cleaning up network before the call to add network.
This way if any change made by add network is reverted by in case of
failure. This is particulary important for physical network interfaces
as with this step we make sure that driver for the physical interface is
reverted back to the original host driver. Without this the physical
network iterface will remain bound to vfio.

Fixes: kata-containers#8646

Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
amshinde added a commit to amshinde/kata-containers that referenced this issue Feb 15, 2024
@amshinde
network: Move up defer block tp cleanup network
71f690a 
Move the defer for cleaning up network before the call to add network.
This way if any change made by add network is reverted by in case of
failure. This is particulary important for physical network interfaces
as with this step we make sure that driver for the physical interface is
reverted back to the original host driver. Without this the physical
network iterface will remain bound to vfio.

Fixes: kata-containers#8646

Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
amshinde added a commit to amshinde/kata-containers that referenced this issue Feb 20, 2024
@amshinde
network: Move up defer block tp cleanup network
b005cda 
Move the defer for cleaning up network before the call to add network.
This way if any change made by add network is reverted by in case of
failure. This is particulary important for physical network interfaces
as with this step we make sure that driver for the physical interface is
reverted back to the original host driver. Without this the physical
network iterface will remain bound to vfio.

Fixes: kata-containers#8646

Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
c3d pushed a commit to c3d/kata-containers that referenced this issue Feb 23, 2024
@amshinde @c3d
network: Move up defer block tp cleanup network
7a39e9c 
Move the defer for cleaning up network before the call to add network.
This way if any change made by add network is reverted by in case of
failure. This is particulary important for physical network interfaces
as with this step we make sure that driver for the physical interface is
reverted back to the original host driver. Without this the physical
network iterface will remain bound to vfio.

Fixes: kata-containers#8646

Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.
Projects
Issue backlog
  
In progress
Milestone
No milestone
1 participant
@amshinde