runtime-rs: guest_id and vhost_fd for VsockDevice should be initialised when necessary #8671
Labels
Projects
Comments
BbolroC
added
enhancement
BbolroC
added a commit
to BbolroC/kata-containers
that referenced
this issue
Dec 14, 2023
As a follow-up for kata-containers#8516, guest_cid and vhost_fd are not necessarily instantiated via new(). Instead, the fields should be initialised later when they are really used to construct hypervisor's parameters. This commit is to separate init_config() from new() to initialise guest_cid and vhost_fd and leave only the assignment of id for the existing function. Fixes: kata-containers#8671 Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
BbolroC
added a commit
to BbolroC/kata-containers
that referenced
this issue
Dec 14, 2023
As a follow-up for kata-containers#8516, guest_cid and vhost_fd are not necessarily initialised via new(). Instead, the fields should be initialised later when they are really used to construct hypervisor's parameters. This commit is to separate init_config() from new() to initialise guest_cid and vhost_fd and leave only the assignment of id for the existing function. Fixes: kata-containers#8671 Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
BbolroC
added a commit
to BbolroC/kata-containers
that referenced
this issue
Dec 15, 2023
As a follow-up for kata-containers#8516, guest_cid and vhost_fd are not necessarily initialised via new(). Instead, the fields should be initialised later when they are really used to construct hypervisor's parameters. This commit is to separate init_config() from new() to initialise guest_cid and vhost_fd and leave only the assignment of id for the existing function. Fixes: kata-containers#8671 Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
BbolroC
added a commit
to BbolroC/kata-containers
that referenced
this issue
Dec 18, 2023
As a follow-up for kata-containers#8516, guest_cid and vhost_fd are not necessarily initialised via new(). Instead, the fields should be initialised later when they are really used to construct hypervisor's parameters. This commit is to separate init_config() from new() to initialise guest_cid and vhost_fd and leave only the assignment of id for the existing function. Fixes: kata-containers#8671 Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
Closed
sprt
pushed a commit
to microsoft/kata-containers
that referenced
this issue
Dec 20, 2023
As a follow-up for kata-containers#8516, guest_cid and vhost_fd are not necessarily initialised via new(). Instead, the fields should be initialised later when they are really used to construct hypervisor's parameters. This commit is to separate init_config() from new() to initialise guest_cid and vhost_fd and leave only the assignment of id for the existing function. Fixes: kata-containers#8671 Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
sprt
pushed a commit
to microsoft/kata-containers
that referenced
this issue
Dec 20, 2023
As a follow-up for kata-containers#8516, guest_cid and vhost_fd are not necessarily initialised via new(). Instead, the fields should be initialised later when they are really used to construct hypervisor's parameters. This commit is to separate init_config() from new() to initialise guest_cid and vhost_fd and leave only the assignment of id for the existing function. Fixes: kata-containers#8671 Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
sprt
pushed a commit
to microsoft/kata-containers
that referenced
this issue
Dec 20, 2023
As a follow-up for kata-containers#8516, guest_cid and vhost_fd are not necessarily initialised via new(). Instead, the fields should be initialised later when they are really used to construct hypervisor's parameters. This commit is to separate init_config() from new() to initialise guest_cid and vhost_fd and leave only the assignment of id for the existing function. Fixes: kata-containers#8671 Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
sprt
pushed a commit
to microsoft/kata-containers
that referenced
this issue
Dec 20, 2023
As a follow-up for kata-containers#8516, guest_cid and vhost_fd are not necessarily initialised via new(). Instead, the fields should be initialised later when they are really used to construct hypervisor's parameters. This commit is to separate init_config() from new() to initialise guest_cid and vhost_fd and leave only the assignment of id for the existing function. Fixes: kata-containers#8671 Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Which feature do you think can be improved?
As a follow-up for #8516 to realise the 2nd step in #8414 (comment), we should separate an initialisation part from an instantiation part for a struct
VsockDevice.The text was updated successfully, but these errors were encountered: