runtime-rs: Separate init_config() from new() for struct VsockDevice #8672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BbolroC
force-pushed
the
introduce-vsock-device-init
branch
from
30090ed
to
47a8205
Compare
studychao
reviewed
Dec 15, 2023
| }) | ||
| } | ||
|
|
||
| pub async fn init_config(&mut self) -> Result<File> { |
There was a problem hiding this comment.
seems like this function is not used anywhere, will the actual usage of this will be introduced later?
There was a problem hiding this comment.
yeah, coming soon from #8185 😉 For the details could you find the last 4 commits at https://github.com/BbolroC/kata-containers/pull/1/commits, for which I got a good feedback from @Apokleos
CC: @pmores
Apokleos
reviewed
Dec 15, 2023
src/runtime-rs/crates/hypervisor/src/device/driver/virtio_vsock.rs
Outdated
Show resolved
Hide resolved
BbolroC
force-pushed
the
introduce-vsock-device-init
branch
from
47a8205
to
dae754d
Compare
|
/test |
gkurz
approved these changes
Dec 18, 2023
gkurz
reviewed
Dec 18, 2023
As a follow-up for kata-containers#8516, guest_cid and vhost_fd are not necessarily initialised via new(). Instead, the fields should be initialised later when they are really used to construct hypervisor's parameters. This commit is to separate init_config() from new() to initialise guest_cid and vhost_fd and leave only the assignment of id for the existing function. Fixes: kata-containers#8671 Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
BbolroC
force-pushed
the
introduce-vsock-device-init
branch
from
dae754d
to
3cd0cc1
Compare
|
/test |
BbolroC
added a commit
to pmores/kata-containers
that referenced
this pull request
Dec 20, 2023
This is to call VsockDevice::init_config() implemented by kata-containers#8672 when vhost_fd and guest_cid should be instantiated. They are immediately passed to a VM instead of staying and being managed by the runtime. Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
BbolroC
added a commit
to BbolroC/kata-containers
that referenced
this pull request
Dec 22, 2023
This is to call VsockDevice::init_config() implemented by kata-containers#8672 when vhost_fd and guest_cid should be instantiated. They are immediately passed to a VM instead of staying and being managed by the runtime. Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up for #8516, guest_cid and vhost_fd are not necessarily initialised via new(). Instead, the fields should be initialised later when they are really used to construct hypervisor's parameters.
This commit is to separate init_config() from new() to initialise guest_cid and vhost_fd and leave only the assignment of id for the existing function.
Fixes: #8671
Signed-off-by: Hyounggyu Choi Hyounggyu.Choi@ibm.com