Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dragonball: Subcrates' unit tests aren't triggered by make test #8690

Closed
justxuewei opened this issue Dec 18, 2023 · 0 comments · Fixed by #8700
Closed

dragonball: Subcrates' unit tests aren't triggered by make test #8690

justxuewei opened this issue Dec 18, 2023 · 0 comments · Fixed by #8700

Comments

@justxuewei
Copy link
Member

No description provided.

@justxuewei justxuewei changed the title dragonball: subcrates' unit tests aren't triggered by make test dragonball: Subcrates' unit tests aren't triggered by make test Dec 18, 2023
justxuewei added a commit to justxuewei/kata-containers that referenced this issue Dec 19, 2023
`make SUPPORT_VIRTUALIZATION=1 test` iterates through all subcrates and
does test.

Plus, this patch fixes some issues about unit tests:

- Feed too much parameters to `I8042Device::new()`.
- Virtqueue checks have been introduced since `virtio-queue v0.7.0`.

Fixes: kata-containers#8690

Signed-off-by: Xuewei Niu <niuxuewei.nxw@antgroup.com>
@katacontainersbot katacontainersbot moved this from To do to In progress in Issue backlog Dec 19, 2023
justxuewei added a commit to justxuewei/kata-containers that referenced this issue Dec 19, 2023
`make SUPPORT_VIRTUALIZATION=1 test` iterates through all subcrates and
does test.

Plus, this patch fixes some issues about unit tests:

- Feed too much parameters to `I8042Device::new()`.
- Virtqueue checks have been introduced since `virtio-queue v0.7.0`.

Fixes: kata-containers#8690

Signed-off-by: Xuewei Niu <niuxuewei.nxw@antgroup.com>
justxuewei added a commit to justxuewei/kata-containers that referenced this issue Dec 19, 2023
`make SUPPORT_VIRTUALIZATION=1 test` iterates through all subcrates and
does test.

Plus, this patch fixes some issues about unit tests:

- Feed too much parameters to `I8042Device::new()`.
- Virtqueue checks have been introduced since `virtio-queue v0.7.0`.
- GHA might have no access to `/var/tmp` dir on runner.

Fixes: kata-containers#8690

Signed-off-by: Xuewei Niu <niuxuewei.nxw@antgroup.com>
sprt pushed a commit to microsoft/kata-containers that referenced this issue Dec 20, 2023
`make SUPPORT_VIRTUALIZATION=1 test` iterates through all subcrates and
does test.

Plus, this patch fixes some issues about unit tests:

- Feed too much parameters to `I8042Device::new()`.
- Virtqueue checks have been introduced since `virtio-queue v0.7.0`.
- GHA might have no access to `/var/tmp` dir on runner.

Fixes: kata-containers#8690

Signed-off-by: Xuewei Niu <niuxuewei.nxw@antgroup.com>
sprt pushed a commit to microsoft/kata-containers that referenced this issue Dec 20, 2023
`make SUPPORT_VIRTUALIZATION=1 test` iterates through all subcrates and
does test.

Plus, this patch fixes some issues about unit tests:

- Feed too much parameters to `I8042Device::new()`.
- Virtqueue checks have been introduced since `virtio-queue v0.7.0`.
- GHA might have no access to `/var/tmp` dir on runner.

Fixes: kata-containers#8690

Signed-off-by: Xuewei Niu <niuxuewei.nxw@antgroup.com>
sprt pushed a commit to microsoft/kata-containers that referenced this issue Dec 20, 2023
`make SUPPORT_VIRTUALIZATION=1 test` iterates through all subcrates and
does test.

Plus, this patch fixes some issues about unit tests:

- Feed too much parameters to `I8042Device::new()`.
- Virtqueue checks have been introduced since `virtio-queue v0.7.0`.
- GHA might have no access to `/var/tmp` dir on runner.

Fixes: kata-containers#8690

Signed-off-by: Xuewei Niu <niuxuewei.nxw@antgroup.com>
sprt pushed a commit to microsoft/kata-containers that referenced this issue Dec 20, 2023
`make SUPPORT_VIRTUALIZATION=1 test` iterates through all subcrates and
does test.

Plus, this patch fixes some issues about unit tests:

- Feed too much parameters to `I8042Device::new()`.
- Virtqueue checks have been introduced since `virtio-queue v0.7.0`.
- GHA might have no access to `/var/tmp` dir on runner.

Fixes: kata-containers#8690

Signed-off-by: Xuewei Niu <niuxuewei.nxw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Issue backlog
  
In progress
Development

Successfully merging a pull request may close this issue.

1 participant