Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dragonball: Trigger unit tests of dbs_* subcrates by make test #8700

Merged
merged 1 commit into from Dec 19, 2023

Conversation

justxuewei
Copy link
Member

@justxuewei justxuewei commented Dec 19, 2023

make SUPPORT_VIRTUALIZATION=1 test iterates through all subcrates and
does test.

Plus, this patch fixes some issues about unit tests:

  • Feed too much parameters to I8042Device::new().
  • Virtqueue checks have been introduced since virtio-queue v0.7.0.
  • GHA might have no access to /var/tmp dir on runner.

Fixes: #8690

@justxuewei
Copy link
Member Author

/test

Copy link
Contributor

@Apokleos Apokleos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @justxuewei LGTM!

`make SUPPORT_VIRTUALIZATION=1 test` iterates through all subcrates and
does test.

Plus, this patch fixes some issues about unit tests:

- Feed too much parameters to `I8042Device::new()`.
- Virtqueue checks have been introduced since `virtio-queue v0.7.0`.
- GHA might have no access to `/var/tmp` dir on runner.

Fixes: kata-containers#8690

Signed-off-by: Xuewei Niu <niuxuewei.nxw@antgroup.com>
@justxuewei
Copy link
Member Author

/test

@justxuewei justxuewei merged commit ec30d5a into kata-containers:main Dec 19, 2023
169 of 216 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test size/small Small and simple task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dragonball: Subcrates' unit tests aren't triggered by make test
4 participants