Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dragonball: connot compile when virtio-net feature is on and vhost-user-net is off #8742

Closed
studychao opened this issue Dec 27, 2023 · 0 comments · Fixed by #8744
Closed

Dragonball: connot compile when virtio-net feature is on and vhost-user-net is off #8742

studychao opened this issue Dec 27, 2023 · 0 comments · Fixed by #8744
Projects
Issue backlog

Comments

@studychao
Copy link
Member

image
This line of code will be activated when virtio-net feature is on but VhostUserConfig need vhost-user-net feature on, so this line of code could not compile when only virtio-net is on.
justxuewei added a commit to justxuewei/kata-containers that referenced this issue Dec 28, 2023
@justxuewei
dragonball: Fix compilation issue without all net features
aac76f4 
Combinations of network features were tested:

- None
- virtio-net
- vhost-net
- vhost-user-net
- virtio-net,vhost-net
- vhost-net,vhost-user-net
- virtio-net,vhost-user-net
- virtio-net,vhost-net,vhost-user-net

Fixes: kata-containers#8742

Signed-off-by: Xuewei Niu <niuxuewei.nxw@antgroup.com>
@justxuewei justxuewei mentioned this issue Dec 28, 2023
Merged
@katacontainersbot katacontainersbot moved this from To do to In progress in Issue backlog Dec 28, 2023
justxuewei added a commit to justxuewei/kata-containers that referenced this issue Dec 28, 2023
@justxuewei
dragonball: Fix compilation issue without all net features
4c023e3 
Combinations of network features were tested:

- None
- virtio-net
- vhost-net
- vhost-user-net
- virtio-net,vhost-net
- vhost-net,vhost-user-net
- virtio-net,vhost-user-net
- virtio-net,vhost-net,vhost-user-net

Fixes: kata-containers#8742

Signed-off-by: Xuewei Niu <niuxuewei.nxw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Issue backlog
  
In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dragonball: Fix compilation issue without all net features justxuewei/kata-containers
1 participant
@studychao