Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dragonball: Fix compilation issue without all net features #8744

Merged
merged 1 commit into from Jan 4, 2024

Conversation

justxuewei
Copy link
Member

Combinations of network features were tested:

  • None
  • virtio-net
  • vhost-net
  • vhost-user-net
  • virtio-net,vhost-net
  • vhost-net,vhost-user-net
  • virtio-net,vhost-user-net
  • virtio-net,vhost-net,vhost-user-net

Fixes: #8742

@katacontainersbot katacontainersbot added the size/large Task of significant size label Dec 28, 2023
Combinations of network features were tested:

- None
- virtio-net
- vhost-net
- vhost-user-net
- virtio-net,vhost-net
- vhost-net,vhost-user-net
- virtio-net,vhost-user-net
- virtio-net,vhost-net,vhost-user-net

Fixes: kata-containers#8742

Signed-off-by: Xuewei Niu <niuxuewei.nxw@antgroup.com>
@justxuewei
Copy link
Member Author

/test

@justxuewei
Copy link
Member Author

/test

Copy link
Contributor

@Apokleos Apokleos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @justxuewei LGTM!

@justxuewei justxuewei merged commit b5a6e74 into kata-containers:main Jan 4, 2024
176 of 181 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test size/large Task of significant size
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dragonball: connot compile when virtio-net feature is on and vhost-user-net is off
4 participants