runtime-rs doesn't work with cri-o #8985
Labels
Projects
Comments
pmores
added
bug
pmores
added a commit
to pmores/kata-containers
that referenced
this issue
Feb 1, 2024
Since cri-o doesn't seem to use address for event publishing as mentioned in the previous commit it will not send it. However, the exactl way of not sending it is unfortunately different from what is assumed by runtime-rs. Due to an implementation detail of cri-o which uses containerd libraries for some low-level tasks, TTRPC_ADDRESS will not be missing from environment as assumed, instead it will be present with an empty value. This commit contains a small adjustment to account for that and use LogForwarder even if TTRPC_ADDRESS is present, but with an empty value. Fixes kata-containers#8985 Signed-off-by: Pavel Mores <pmores@redhat.com>
pmores
added a commit
to pmores/kata-containers
that referenced
this issue
Feb 6, 2024
Since cri-o doesn't seem to use address for event publishing as mentioned in the previous commit it will not send it. However, the exact way of not sending it is unfortunately different from what is assumed by runtime-rs. Due to an implementation detail of cri-o which uses containerd libraries for some low-level tasks, TTRPC_ADDRESS will not be missing from environment as assumed, instead it will be present with an empty value. This commit contains a small adjustment to account for that and use LogForwarder even if TTRPC_ADDRESS is present, but with an empty value. Fixes kata-containers#8985 Signed-off-by: Pavel Mores <pmores@redhat.com>
pmores
added a commit
to pmores/kata-containers
that referenced
this issue
Feb 6, 2024
Since cri-o doesn't seem to use address for event publishing as mentioned in the previous commit it will not send it. However, the exact way of not sending it is unfortunately different from what is assumed by runtime-rs. Due to an implementation detail of cri-o which uses containerd libraries for some low-level tasks, TTRPC_ADDRESS will not be missing from environment as assumed, instead it will be present with an empty value. This commit contains a small adjustment to account for that and use LogForwarder even if TTRPC_ADDRESS is present, but with an empty value. Fixes kata-containers#8985 Signed-off-by: Pavel Mores <pmores@redhat.com>
c3d
pushed a commit
to c3d/kata-containers
that referenced
this issue
Feb 23, 2024
Since cri-o doesn't seem to use address for event publishing as mentioned in the previous commit it will not send it. However, the exact way of not sending it is unfortunately different from what is assumed by runtime-rs. Due to an implementation detail of cri-o which uses containerd libraries for some low-level tasks, TTRPC_ADDRESS will not be missing from environment as assumed, instead it will be present with an empty value. This commit contains a small adjustment to account for that and use LogForwarder even if TTRPC_ADDRESS is present, but with an empty value. Fixes kata-containers#8985 Signed-off-by: Pavel Mores <pmores@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
runtime-rs cannot currently be launched by cri-o since cri-o passes an empty value for -address which runtime-rs incorrectly rejects.
The text was updated successfully, but these errors were encountered: