Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support host side cgroups v2 #927

Closed
jodh-intel opened this issue Oct 12, 2020 · 9 comments
Closed

Support host side cgroups v2 #927

jodh-intel opened this issue Oct 12, 2020 · 9 comments
Labels
area/runtime Issues that impact the runtime (including shimv2) feature New functionality high-priority Very urgent issue (resolve quickly) high-severity Very important issue soc Summer of Code related

Comments

@jodh-intel
Copy link
Contributor

Problem

The runtime doesn't support cgroups v2 on the host.

$ egrep -r  "\<cgroupsLoadFunc\(|parentCgroup\(" | grep '[12]'
virtcontainers/container.go:    cgroup, err := cgroupsLoadFunc(cgroups.V1,
virtcontainers/container.go:    parent, err := parentCgroup(cgroups.V1, c.state.CgroupPath)
virtcontainers/container.go:    cgroup, err := cgroupsLoadFunc(cgroups.V1,
virtcontainers/sandbox.go:      cgroup, err := cgroupsLoadFunc(V1Constraints, cgroups.StaticPath(s.state.CgroupPath))

Consequence

This means we cannot run on F31 and F32, which default to cgroups v2 only without the user performing surgery on their system (reverting to cgroups v1 by changing bootloader stuff and rebooting - yikes!)

Related:

@jodh-intel jodh-intel added high-priority Very urgent issue (resolve quickly) feature New functionality high-severity Very important issue needs-review Needs to be assessed by the team. labels Oct 12, 2020
@ariel-adam ariel-adam removed the needs-review Needs to be assessed by the team. label Feb 2, 2021
@ariel-adam
Copy link
Contributor

@jodh-intel was this already fixed?

@ariel-adam ariel-adam added the area/runtime Issues that impact the runtime (including shimv2) label Feb 2, 2021
@azenla
Copy link

azenla commented Aug 22, 2021

This could be more important very soon. Ubuntu 21.10 is going to ship with cgroups v2 enabled by default: https://www.phoronix.com/scan.php?page=news_item&px=Ubuntu-21.10-systemd-cgroup

@itplayer-de
Copy link

Is there any news or a roadmap here? Also Debian 11 "bullseye" now has cgroups v2 as default. Containerd runs in a "mountpoint does not exist" (also with setting sandbox_cgroup_only=true). Thx & regards

@zvonkok
Copy link
Contributor

zvonkok commented Mar 1, 2022

Arch and all derivates (EndeavourOS, Manjaro, Garuda) have also per default cgroup v2.

@liyimeng
Copy link

What is blocking this from fixed?

@liubin
Copy link
Member

liubin commented May 24, 2022

@jodh-intel we are joining a summer code and can I assign this one to others if you are not started yet?

@liubin liubin added the soc Summer of Code related label May 24, 2022
@jodh-intel
Copy link
Contributor Author

Hi @liubin - yes, please do! ;) I was not involved in discussions on this being assigned to me, and don't have the time to look at it.

@bradennapier
Copy link

:( Manjaro no bueno due to this it seems!

@jodh-intel
Copy link
Contributor Author

This issue should have been closed when #4397 landed (issue #3073).

See: https://github.com/kata-containers/kata-containers/blob/main/docs/design/host-cgroups.md

Closing this issue, but I've raised #6259 to fix kata-manager which by default fails (incorrectly) when run on a cgroupsv2 system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/runtime Issues that impact the runtime (including shimv2) feature New functionality high-priority Very urgent issue (resolve quickly) high-severity Very important issue soc Summer of Code related
Projects
None yet
Development

No branches or pull requests

8 participants