tracing: Remove whitespace from root span #4484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove space from root span name to follow camel casing of other tracing span names in the runtime and to make parsing easier in testing. Fixes kata-containers#4483 Signed-off-by: Chelsea Mafrica <chelsea.e.mafrica@intel.com>
|
/test |
|
jenkins-ci-ARM-ubuntu-18-04: |
|
/retest-arm |
cmaf
added a commit
to cmaf/tests
that referenced
this pull request
Jun 17, 2022
Still WIP. Add check for spans specified in test data in jaeger tracing output. Verify relative ordering of spans to test that spans occur in an expected order. For example, test that some agent calls occur after specific runtime calls, and that both occur under the root span. Depends-on: github.com/kata-containers/kata-containers#4484 Fixes Signed-off-by: Chelsea Mafrica <chelsea.e.mafrica@intel.com>
liubin
approved these changes
Jun 20, 2022
fidencio
approved these changes
Jun 20, 2022
cmaf
added a commit
to cmaf/tests
that referenced
this pull request
Jun 27, 2022
Still WIP. Add check for spans specified in test data in jaeger tracing output. Verify relative ordering of spans to test that spans occur in an expected order. For example, test that some agent calls occur after specific runtime calls, and that both occur under the root span. Depends-on: github.com/kata-containers/kata-containers#4484 Fixes Signed-off-by: Chelsea Mafrica <chelsea.e.mafrica@intel.com>
cmaf
added a commit
to cmaf/tests
that referenced
this pull request
Jun 27, 2022
Still WIP. Add check for spans specified in test data in jaeger tracing output. Verify relative ordering of spans to test that spans occur in an expected order. For example, test that some agent calls occur after specific runtime calls, and that both occur under the root span. Depends-on: github.com/kata-containers/kata-containers#4484 Fixes Signed-off-by: Chelsea Mafrica <chelsea.e.mafrica@intel.com>
cmaf
added a commit
to cmaf/tests
that referenced
this pull request
Jun 27, 2022
Still WIP. Add check for spans specified in test data in jaeger tracing output. Verify relative ordering of spans to test that spans occur in an expected order. For example, test that some agent calls occur after specific runtime calls, and that both occur under the root span. Depends-on: github.com/kata-containers/kata-containers#4484 Fixes Signed-off-by: Chelsea Mafrica <chelsea.e.mafrica@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove space from root span name to follow camel casing of other tracing
span names in the runtime and to make parsing easier in testing.
Fixes #4483
Signed-off-by: Chelsea Mafrica chelsea.e.mafrica@intel.com