Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oci: fix serde skip serializing condition #4574

Merged
merged 1 commit into from
Jul 5, 2022
Merged

oci: fix serde skip serializing condition #4574

merged 1 commit into from
Jul 5, 2022

Conversation

jelipo
Copy link
Contributor

@jelipo jelipo commented Jul 1, 2022 •
edited
Loading

There is an extra space on the serde serialization condition.

Fixes: #4578

Signed-off-by: haining.cao haining.cao@daocloud.io

@katacontainersbot katacontainersbot added the size/tiny Smallest and simplest task label Jul 1, 2022
@liubin
Copy link
Member

liubin commented Jul 1, 2022

Thank you @jelipo
Kata Containers has its patch format, you should refer to this to let your code pass the CI.

And also, you can refer to any merged PRs too.

@jelipo jelipo changed the title Fix serde skip serializing condition oci: fix serde skip serializing condition Jul 1, 2022
@jelipo
Copy link
Contributor Author

jelipo commented Jul 1, 2022 •
edited
Loading

@liubin
Sorry
I updated my PR info.

@liubin
Copy link
Member

liubin commented Jul 4, 2022

Hi @jelipo
you need to create an issue to describe the problem and add a "Fixes: #xxx" in your commit.

@jelipo
Copy link
Contributor Author

jelipo commented Jul 4, 2022

@liubin
Thanks. I updated it.

@liubin
Copy link
Member

liubin commented Jul 4, 2022

@jelipo There is still an error:

Found 1 commit between commit HEAD and branch main
ERROR: Commit 1cab14f: subject too long (max 75, got 103): "oci: fix serde skip serializing condition There is an extra space on the serde serialization condition."
ERROR: checkcommits failed. See the document below for help on formatting
commits for the project.

Can you make your commit message more shorter by adding some new lines?

@jelipo
oci: fix serde skip serializing condition
0ddb34a 
There is an extra space on the serde serialization condition.

Fixes: #4578

Signed-off-by: haining.cao <haining.cao@daocloud.io>
@jelipo
Copy link
Contributor Author

jelipo commented Jul 4, 2022

@liubin Ok

@ManaSugi
Copy link
Member

ManaSugi commented Jul 4, 2022

/test

@liubin
Copy link
Member

liubin commented Jul 5, 2022

/test-vfio

@liubin
Copy link
Member

liubin commented Jul 5, 2022

/test-vfio

@liubin liubin merged commit b33ad7e into kata-containers:main Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergwolf bergwolf bergwolf approved these changes

@liubin liubin liubin approved these changes

Assignees
No one assigned
Labels
size/tiny Smallest and simplest task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

There is an extra space on the serde serialization condition
5 participants
@jelipo @liubin @ManaSugi @bergwolf @katacontainersbot