-
Notifications
You must be signed in to change notification settings - Fork 997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
# Kata Containers 3.0.2 #6282
# Kata Containers 3.0.2 #6282
Conversation
/test |
/test_kata_deploy |
1 similar comment
/test_kata_deploy |
This is not working as it seems the action will always be read from the This, most likely, will also affect the release. |
@fidencio Yeah not sure why that is happening, I referred to the workflow of previous release(3.0.1) that you had done, and I see that it uses the workflow file from stable branch to run: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @amshinde.
lgtm
Another simpler approach could be to backport #6141 |
6282ec7
to
f7f5440
Compare
/test_kata_deploy |
/test |
Ouch, it seems way more patches would need to be backported. :-/ |
@amshinde, so, this seems to be the correct behaviour when we're using an action based on |
Please, drop the extra patches, let's have this one merged without the kata-deploy test (and, pretty please, open an issue for this), and it won't affect the release itself. |
kata-deploy files must be adapted to a new release. The cases where it happens are when the release goes from -> to: * main -> stable: * kata-deploy-stable / kata-cleanup-stable: are removed * stable -> stable: * kata-deploy / kata-cleanup: bump the release to the new one. There are no changes when doing an alpha release, as the files on the "main" branch always point to the "latest" and "stable" tags. Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
- stable-3.0: Stable 3.0 backports - stable-3.0 | docs: Fix missing critical steps in how-to-hotplug-memory-arm64.md - Stable-3.0 | Upgrade to Cloud Hypervisor v28.2 - Qemu logs for stable 3.0 - Backport CI fixes for s390x and ppc64le to stable-3.0 - docs: Fix missing critical steps in how-to-hotplug-memory-arm64.md - Stable-3.0 | Upgrade to Cloud Hypervisor v28.1 4ebeb51 release: Adapt kata-deploy for 3.0.2 178ee3d agent: check command before do test_ip_tables 7461bcd runtime-rs: change cache mode 123c867 SEV: Update ReducedPhysBits 98f60c1 clh: Enforce API timeout only for vm.boot request 960f089 virtiofsd: fix the build on ppc64le 92f3b11 runtime:all APIs are hang in the service.mu 92619c8 runtime: Drop QEMU log file support 4f3db76 runtime: Collect QEMU's stderr 918c11e runtime: Start QEMU undaemonized 8c4507b runtime: Launch QEMU with cmd.Start() a61fba6 runtime: Pre-establish the QMP connection ad9cb0b govmm: Optionally pass QMP listener to QEMU d6dd99e govmm: Optionally start QMP with a pre-configured connection 0623f1f virtiofsd: Not use "link-self-contained=yes" on s390x 5883dc1 CI: Set docker version to v20.10 in ubuntu:20.04 for s390x|ppc64le 4a5877f docs: Fix missing critical steps in how-to-hotplug-memory-arm64.md d3b5732 versions: Upgrade to Cloud Hypervisor v28.2 0d7bd06 docs: Fix missing critical steps in how-to-hotplug-memory-arm64.md ac1ce2d docs: Fix missing critical steps in how-to-hotplug-memory-arm64.md f4d71af docs: Fix missing critical steps in how-to-hotplug-memory-arm64.md fcc120d versions: Upgrade to Cloud Hypervisor v28.1 Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
f7f5440
to
2f638b3
Compare
/test |
/test_kata_deploy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @amshinde!
The /test_kata_deploy
won't pass, but it won't affect the release workflow.
@fidencio The github docs do mention The SHA that the workflow points to is the version bump sha on the stable 3.0 branch rather than main branch. Which really doesnt add up, unless github changed the behaviour+docs recently. |
The SHA on the workflow points to 2e54c8e, which was the last commit on We do some tricks in order to get the correct SHA as part of each task of the action, but then if a new task's been added, we end up failing, which is the case right now. :-/ |
/test-vfio |
This is a commit that's a pre-req for kata-containers#6282, as that PR will merge log-parser-rs into kata-ctl, but that will result in a CI breakage. So, let's deal with the CI changes here, thanks to GHA and our favourite `pull_request_target` event, unblocking that PR to be merged. Fixes: kata-containers#6797 (not really, but related). Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com>
4ebeb51 release: Adapt kata-deploy for 3.0.2
178ee3d agent: check command before do test_ip_tables
7461bcd runtime-rs: change cache mode
123c867 SEV: Update ReducedPhysBits
98f60c1 clh: Enforce API timeout only for vm.boot request
960f089 virtiofsd: fix the build on ppc64le
92f3b11 runtime:all APIs are hang in the service.mu
92619c8 runtime: Drop QEMU log file support
4f3db76 runtime: Collect QEMU's stderr
918c11e runtime: Start QEMU undaemonized
8c4507b runtime: Launch QEMU with cmd.Start()
a61fba6 runtime: Pre-establish the QMP connection
ad9cb0b govmm: Optionally pass QMP listener to QEMU
d6dd99e govmm: Optionally start QMP with a pre-configured connection
0623f1f virtiofsd: Not use "link-self-contained=yes" on s390x
5883dc1 CI: Set docker version to v20.10 in ubuntu:20.04 for s390x|ppc64le
4a5877f docs: Fix missing critical steps in how-to-hotplug-memory-arm64.md
d3b5732 versions: Upgrade to Cloud Hypervisor v28.2
0d7bd06 docs: Fix missing critical steps in how-to-hotplug-memory-arm64.md
ac1ce2d docs: Fix missing critical steps in how-to-hotplug-memory-arm64.md
f4d71af docs: Fix missing critical steps in how-to-hotplug-memory-arm64.md
fcc120d versions: Upgrade to Cloud Hypervisor v28.1