Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: Stop building / shipping log-parser-rs #8528

Conversation

fidencio
Copy link
Member

@fidencio fidencio commented Nov 29, 2023

This is a commit that's a pre-req for #6826, as that PR will merge log-parser-rs into kata-ctl, but that will result in a CI breakage.

So, let's deal with the CI changes here, thanks to GHA and our favourite pull_request_target event, unblocking that PR to be merged.

Fixes: #6797 (not really, but related).

@fidencio
Copy link
Member Author

/test

Copy link
Member

@gkurz gkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reference PR #6826 instead of #6282 in the changelog. Apart from that, rest LGTM. Thanks @fidencio !

This is a commit that's a pre-req for kata-containers#6826, as that PR will merge
log-parser-rs into kata-ctl, but that will result in a CI breakage.

So, let's deal with the CI changes here, thanks to GHA and our favourite
`pull_request_target` event, unblocking that PR to be merged.

Fixes: kata-containers#6797 (not really, but related).

Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com>
@fidencio fidencio force-pushed the topic/stop-building-and-shipping-log-parser-rs branch from b764f63 to 1284b4e Compare November 29, 2023 23:32
@fidencio
Copy link
Member Author

/test

@fidencio fidencio merged commit 80fcc56 into kata-containers:main Nov 30, 2023
164 of 169 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test size/tiny Smallest and simplest task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding the rust log-parser to kata-ctl
4 participants