New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: genpolicy static checks #8814
tools: genpolicy static checks #8814
Conversation
897e491
to
2a232de
Compare
2a232de
to
b3d3ff3
Compare
@danmihai1, ideally we'd like to have the genpolicy built as part of each PR, so we make sure we won't break it for one reason or another. We can achieve this by squashing this patch to your series:
|
Package genpolicy and enable static checks for it. Fixes: kata-containers#8813 Signed-off-by: Dan Mihai <dmihai@microsoft.com>
b3d3ff3
to
201eec6
Compare
Thanks! That was waiting for: but it's done now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @danmihai1!
hi @danmihai1 ! I could build it locally with Kind off-topic, I had never played with the tool then I have it a try. I got the following yaml not parsed (couldn't recognize the
Without
|
Actually I figured it should have a line break to separate the end of the policy and the begin of the pod yaml:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @danmihai1 !
Thanks for the feedback @wainersm! Please create an issue for the missing spec.dnsPolicy support if you want - otherwise I will create it. |
/test |
I can create the issue. ywc! |
Package genpolicy and enable static checks for it.
Fixes: #8813