Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

genpolicy: cargo clippy fixes #8822

Merged
merged 1 commit into from Jan 15, 2024

Conversation

danmihai1
Copy link
Contributor

Clean up cargo clippy errors.

Fixes: #8818

Clean up cargo clippy errors.

Fixes: kata-containers#8818

Signed-off-by: Dan Mihai <dmihai@microsoft.com>
@stevenhorsman
Copy link
Member

/test

Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes LGTM and using rust 1.72.0 matching the versions.yaml there were no clippy errors when I tried it locally after this change:

genpolicy stevenh$ cargo clippy --all-features --release -- -D warnings
    Finished release [optimized] target(s) in 0.21s

Thanks Dan!

Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @danmihai1!

@fidencio
Copy link
Member

/test-arm

@fidencio fidencio merged commit 0dc00ae into kata-containers:main Jan 15, 2024
183 of 198 checks passed
@danmihai1 danmihai1 deleted the danmihai1/cargo-clippy branch January 15, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test size/large Task of significant size
Projects
None yet
Development

Successfully merging this pull request may close these issues.

genpolicy: cargo clippy errors
4 participants